You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/02/10 18:36:45 UTC

[GitHub] [trafficserver] SolidWallOfCode opened a new pull request, #9397: Remove absolute libswoc include paths.

SolidWallOfCode opened a new pull request, #9397:
URL: https://github.com/apache/trafficserver/pull/9397

   This fixes some issues with libswoc from the merge of 10-Dev to master.
   
   *  There were some absolute paths for libswoc headers which caused conflicts with external libswoc use.
   *  Some `@SWOC_INCLUDES@` were missing (this caused the "string_view_util.h" issue).
   *  Tweaked up the libswoc checks to handle `-ltsswoc` vs. `-lswoc`.
   
   For external libswoc use, this now assumes there is a "libswoc.so" to link. This should be done with a symlink in the standard way. The internal built libswoc is named "libtsswoc.so" to help avoid collisions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] dragon512 commented on a diff in pull request #9397: Remove absolute libswoc include paths.

Posted by "dragon512 (via GitHub)" <gi...@apache.org>.
dragon512 commented on code in PR #9397:
URL: https://github.com/apache/trafficserver/pull/9397#discussion_r1103169755


##########
build/libswoc.m4:
##########
@@ -51,26 +51,29 @@ AC_ARG_WITH(libswoc, [AS_HELP_STRING([--with-libswoc=DIR],[use a specific libswo
     AC_MSG_RESULT([not found])
   fi
 
-if test "$has_libswoc" != "no"; then
-  saved_ldflags=$LDFLAGS
-  saved_cppflags=$CPPFLAGS
+  if test "$has_libswoc" != "no"; then
+    saved_ldflags=$LDFLAGS
+    saved_cppflags=$CPPFLAGS
 
-  SWOC_LIBS=-ltsswoc
-  if test "$libswoc_base_dir" != "/usr"; then
-    SWOC_INCLUDES=-I${swoc_include}
-    SWOC_LDFLAGS=-L${swoc_ldflags}
+    SWOC_LIBS=-lswoc

Review Comment:
   Can this value be set via the pkg-config file instead??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode merged pull request #9397: Build: improve libswoc building.

Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode merged PR #9397:
URL: https://github.com/apache/trafficserver/pull/9397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9397: Remove absolute libswoc include paths.

Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on code in PR #9397:
URL: https://github.com/apache/trafficserver/pull/9397#discussion_r1105076228


##########
build/libswoc.m4:
##########
@@ -51,26 +51,29 @@ AC_ARG_WITH(libswoc, [AS_HELP_STRING([--with-libswoc=DIR],[use a specific libswo
     AC_MSG_RESULT([not found])
   fi
 
-if test "$has_libswoc" != "no"; then
-  saved_ldflags=$LDFLAGS
-  saved_cppflags=$CPPFLAGS
+  if test "$has_libswoc" != "no"; then
+    saved_ldflags=$LDFLAGS
+    saved_cppflags=$CPPFLAGS
 
-  SWOC_LIBS=-ltsswoc
-  if test "$libswoc_base_dir" != "/usr"; then
-    SWOC_INCLUDES=-I${swoc_include}
-    SWOC_LDFLAGS=-L${swoc_ldflags}
+    SWOC_LIBS=-lswoc

Review Comment:
   Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org