You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/19 07:53:43 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10109: Setting up test for alert-api starting with testing AlertResult Class

SbloodyS commented on PR #10109:
URL: https://github.com/apache/dolphinscheduler/pull/10109#issuecomment-1131362689

   > > Hi @kezhenxu94 , The purpose of adding these tests is to expand the test coverage in this application and to test different classes for their functionalities.
   > 
   > We don't blindly chase test coverage. The test here is basically testing some generated codes (equals, hascode), which I don't think is necessary, if you are interested in adding test, please consider add other meaningful tests
   
   I agreed with @kezhenxu94 . I will close this PR. Looking forward to your new contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org