You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by st...@apache.org on 2011/11/01 17:31:30 UTC
svn commit: r1196103 - in
/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default:
myfaces-checks-standard.xml myfaces-checks-strict.xml
Author: struberg
Date: Tue Nov 1 16:31:30 2011
New Revision: 1196103
URL: http://svn.apache.org/viewvc?rev=1196103&view=rev
Log:
MYFACES-3368 disable the DoubleCheckLock idiom test
since dcl works with java5 and use of volatile
Modified:
myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml
myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml
Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml?rev=1196103&r1=1196102&r2=1196103&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml Tue Nov 1 16:31:30 2011
@@ -114,6 +114,7 @@
<!-- Checks for imports -->
<!-- See http://checkstyle.sf.net/config_import.html -->
<module name="AvoidStarImport">
+ <property name="excludes" value="java.io,java.net,java.lang.Math,org.apache.myfaces.config.impl.digester.elements"/>
<property name="allowStaticMemberImports" value="true"/>
</module>
<module name="IllegalImport"/>
@@ -147,7 +148,9 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
- <module name="DoubleCheckedLocking"/>
+ <!-- DISABLED, because DoubleCheckLock is perfectly valid now as of Java5. See JSR-133
+ * <module name="DoubleCheckedLocking"/>
+ -->
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="InnerAssignment"/>
Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml?rev=1196103&r1=1196102&r2=1196103&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml Tue Nov 1 16:31:30 2011
@@ -114,7 +114,7 @@
<property name="ignorePattern" value="@version|@see"/>
</module>
<module name="MethodLength">
- <property name="max" value="200" />
+ <property name="max" value="300" />
</module>
<module name="ParameterNumber">
<property name="max" value="10" />
@@ -143,7 +143,9 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
- <module name="DoubleCheckedLocking"/>
+ <!-- DISABLED, because DoubleCheckLock is perfectly valid now as of Java5. See JSR-133
+ * <module name="DoubleCheckedLocking"/>
+ -->
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="InnerAssignment"/>