[GitHub] [gora] jhnmora000 commented on a change in pull request #227: XSD validation for Lucene datastore

[GitBox <gi...@apache.org>]

jhnmora000 commented on a change in pull request #227:
URL: https://github.com/apache/gora/pull/227#discussion_r511645196



##########
File path: gora-lucene/src/test/conf/gora-lucene.xsd
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8" ?>

Review comment:
       IMHO, a schema file should not be placed in the tests of the datastore

##########
File path: gora-lucene/src/test/conf/gora-lucene.xsd
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">

Review comment:
       please add the Apache 2.0 License notice for this file

##########
File path: gora-lucene/src/test/conf/gora-lucene.xsd
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
+
+    <xs:element name="gora-otd" type="lucene-mapping"/>

Review comment:
       format this file with 2-space indentation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org