[jira] Updated: (IVY-864) HTTP Handlers ignore unsuccessful response codes.

["James P. White (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IVY-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James P. White updated IVY-864:
-------------------------------

    Attachment: http_download_response_patch.txt

This is a patch to BasicURLHandler and HttpClientHandler so that they will only successfully download a file if the HTTP response code is 2XX.  I think that is pretty much the right thing to do for starters (more elaborate would be dealing with redirection 3XX).

> HTTP Handlers ignore unsuccessful response codes.
> -------------------------------------------------
>
>                 Key: IVY-864
>                 URL: https://issues.apache.org/jira/browse/IVY-864
>             Project: Ivy
>          Issue Type: Bug
>            Reporter: James P. White
>         Attachments: http_download_response_patch.txt
>
>
> The HttpClientHander.download and BasicURLHandler.download methods don't bother to check the HTTP response code from the server.  As a result they will put anything that the server sends back as the contents of the artifact.  This isn't so good if it is something like the HTML message for a 404 or 503 and what you wanted was a JAR file.  In fact it is pretty bad because then the cache is poisoned and the user is left with purging the cache as the only solution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.