You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/12 19:03:20 UTC

[GitHub] [superset] paulinjo opened a new pull request, #19670: fix: Add serviceAccountName to celerybeat pods

paulinjo opened a new pull request, #19670:
URL: https://github.com/apache/superset/pull/19670

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Fixes #19669
   
   This PR adds the serviceAccountName spec to celerybeat pods when deploying with Helm.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   1. Set the serviceAccountName and supersetCeleryBeat.enabled:true in the values.yml file for helm deployment
   2. Deploy using Helm
   3. Observe the serviceAccountName spec on the celeryBeat pods.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] dpgaspar commented on a diff in pull request #19670: fix: Add serviceAccountName to celerybeat pods

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on code in PR #19670:
URL: https://github.com/apache/superset/pull/19670#discussion_r890071776


##########
helm/superset/Chart.yaml:
##########
@@ -22,7 +22,7 @@ maintainers:
   - name: craig-rueda
     email: craig@craigrueda.com
     url: https://github.com/craig-rueda
-version: 0.6.1
+version: 0.6.2

Review Comment:
   can you plz bump the version again, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai merged pull request #19670: fix: Add serviceAccountName to celerybeat pods

Posted by GitBox <gi...@apache.org>.
nytai merged PR #19670:
URL: https://github.com/apache/superset/pull/19670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #19670: fix: Add serviceAccountName to celerybeat pods

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #19670:
URL: https://github.com/apache/superset/pull/19670#discussion_r848784204


##########
helm/superset/templates/deployment-beat.yaml:
##########
@@ -59,6 +59,9 @@ spec:
         {{ toYaml .Values.supersetCeleryBeat.podLabels | nindent 8 }}
       {{- end }}
     spec:
+      { { - if or (.Values.serviceAccount.create) (.Values.serviceAccountName) } }

Review Comment:
   Pls remove extra spaces between curly brackets



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] dpgaspar closed pull request #19670: fix: Add serviceAccountName to celerybeat pods

Posted by GitBox <gi...@apache.org>.
dpgaspar closed pull request #19670: fix: Add serviceAccountName to celerybeat pods
URL: https://github.com/apache/superset/pull/19670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org