You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/05 08:47:39 UTC
[GitHub] [doris] ByteYue opened a new pull request, #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
ByteYue opened a new pull request, #13983:
URL: https://github.com/apache/doris/pull/13983
# Proposed changes
Previously in Doris FE, there is no specific thread pool for grpc-client-channel, by default the underlying netty logic would use one static threadpool whose size is set the 2 * coreNum. The workload for this grpc threadpool is unseen.
Use ThreadpoolMgr to create one customized threadpool to get Prometheus-compatible metric data.
Issue Number: close #xxx
## Problem summary
Describe your changes.
Use ThreadpoolMgr to create one customized threadpool for grpc's NettyChannel instead of the default threadpool of grpc.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1304704132
> > The previous default pool num is 2 * core num. But you change it to 8 as default, which may be less than previous value?
>
> Yes... It's a little bit confusing me to choose which num to use as the default size. Any advice?😂
My point is, does increase this pool size really solve the problem?
Because you set a smaller default pool size, so I think you have tested it and resolve the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1495430879
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1312674579
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.23 seconds
load time: 496 seconds
storage size: 17180563873 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221113084705_clickbench_pr_45065.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #13983:
URL: https://github.com/apache/doris/pull/13983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1304452656
The previous default pool num is 2 * core num.
But you change it to 8 as default, which may be less than previous value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by GitBox <gi...@apache.org>.
ByteYue commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1304459563
> The previous default pool num is 2 * core num. But you change it to 8 as default, which may be less than previous value?
Yes... It's a little bit confusing me to choose which num to use as the default size. Any advice?😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1495863844
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1497433066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xxiao2018 commented on pull request #13983: [Enhancement](FE) use customized grpc threadpool to get better metric for grpc from FE to BE
Posted by GitBox <gi...@apache.org>.
xxiao2018 commented on PR #13983:
URL: https://github.com/apache/doris/pull/13983#issuecomment-1304452535
The previous default pool num is 2 * core num.
But you change it to 8 as default, which may be less than previous value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org