[jira] [Commented] (HBASE-7196) 'hbase shell status' throws exception when HBase is not running

["Elliot Miller (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145045#comment-17145045 ] 

Elliot Miller commented on HBASE-7196:
--------------------------------------

It looks like isMasterRunning was removed from HBaseAdmin by HBASE-14769 (HBase 2.0.0), and then HBaseAdmin itself was deleted more recently, so the above discussion over HBaseAdmin is no longer relevant.

 

As for the original issue, an exception is still being thrown by the shell on 3.0.0-SNAPSHOT:
{code:bash}
elliot@host ~/workspaces/hbase % git show --summary --oneline
8cdb2cca44 (origin/master, origin/HEAD) HBASE-24562: Stabilize master startup with meta replicas enabled (#1903)
elliot@host ~/workspaces/hbase % echo $JAVA_HOME
/Library/Java/JavaVirtualMachines/openjdk-11.jdk/Contents/Home
elliot@host ~/workspaces/hbase % mvn clean install -DskipTests
...
elliot@host ~/workspaces/hbase % ./bin/hbase shell
...
hbase(main):001:0> status

ERROR: Failed contacting masters after 1 attempts.
Exceptions:
java.net.ConnectException: Call to localhost/127.0.0.1:16000 failed on connection exception: org.apache.hbase.thirdparty.io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:16000

For usage try 'help "status"'

Took 0.4340 seconds
hbase(main):002:0>{code}
 

Especially with more recent changes to return objects from shell commands (rather than just printing information), *I think that propagating this exception to the user is still the way to go*.

> 'hbase shell status' throws exception when HBase is not running
> ---------------------------------------------------------------
>
>                 Key: HBASE-7196
>                 URL: https://issues.apache.org/jira/browse/HBASE-7196
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.1
>            Reporter: Oleg Zhurakousky
>            Priority: Major
>
> Its kind of a nuisance bug. One would assume that 'status' command should simply  return something along the lines of "HBase is not running"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)