[jira] [Commented] (JCRVLT-355) False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932141#comment-16932141 ] 

Konrad Windszus commented on JCRVLT-355:
----------------------------------------

A similar false positive can be observed in acs-aem-commons for these filter-rules: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/4903d801bbaad8660cea9b27a671f189d752fbf2/ui.apps/src/main/content/META-INF/vault/filter.xml#L16. 
{code}
[ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.0.5-SNAPSHOT:package (default-package) on project acs-aem-commons-ui.apps: org.apache.maven.plugin.MojoFailureException: Found duplicate files in content package, most probably you have overlapping filter roots or you embed a file which is already there in 'jcrRootSourceDirectory'. For details check the nested exception!: Duplicate file jcr_root/apps/dam/gui/content/assets/metadataeditor/.content.xml was found and the duplicate attribute is 'fail'. -> [Help 1]
{code}
The issue is there that the filter root is below the level of the docview xml file.

> False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory
> -------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-355
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-355
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.4
>            Reporter: Stefan Seifert
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.0.5
>
>
> i've found problem with the check introduced with JCRVLT-279 - or i do not understand why the check leads to a failure in my case.
> i've two projects where this happens:
> 1. conf-content:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/conf-content
> fails with:
> {noformat}
> [ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package (default-package) on project mycompany.myprojectgroup.myproject1.conf-content: org.apache.maven.plugin.MojoFailureException: Found duplicate files in content package, most probably you have overlapping filter roots or you embed a file which is already there in 'jcrRootSourceDirectory'. For details check the nested exception!: Duplicate file jcr_root\conf\myproject1\settings\wcm\policies was found and the duplicate attribute is 'fail'. {noformat}
> 2. ui.apps
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/ui.apps
> fails with:
> {noformat}
> [ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package (default-package) on project mycompany.myprojectgroup.myproject1.ui.apps: org.apache.maven.plugin.MojoFailureException: Found duplicate files in content package, most probably you have overlapping filter roots or you embed a file which is already there in 'jcrRootSourceDirectory'. For details check the nested exception!: Duplicate file jcr_root\apps\epsilon65Project\clientlibs\.content.xml was found and the duplicate attribute is 'fail'.
> {noformat}
> the second project is a special case because in some files in the "clientlibs" folder placeholders are replaced using maven resource filtering, if the corresponding build-helper-maven-plugin definition is removed the build works.
> but the first project is really simple project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)