You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <eh...@gmail.com> on 2007/08/14 08:39:11 UTC
Re: svn trunk r26069: FAIL (win32-xp VS2005)
These breakage failures are caused by code-before-declaration errors
on my side; the first in three_way_merge() [line 164], the other in
two_way_diff() [line 257].
In both cases, the line 'options = options ? options ...' needs to be
moved down below the immediate next block which declares svn_string_t*
variables.
I'm at work, so, if someone could commit this fix, buildbot can start
passing again.
Thanks in advance!
Bye,
Erik.
PS: Is there something in my CFLAGS I can set to prevent this kind of error?
On 8/14/07, buildbot@mobsol.be <bu...@mobsol.be> wrote:
> Full details are available at:
> http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/2020
>
> Author list: blair
>
> Build Slave: djh-xp-vse2005
>
>
> Subversion Buildbot
> http://www.mobsol.be/buildbot/
>
>
> Last 100 lines of the build log (step: Build ):
>
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4024: 'svn_diff_mem_string_output_merge' : different types for formal and actual parameter 4
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4024: 'svn_diff_mem_string_output_merge' : different types for formal and actual parameter 5
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(257): error C2275: 'svn_string_t' : illegal use of this type as an expression
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(258): error C2275: 'svn_string_t' : illegal use of this type as an expression
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4024: 'svn_diff_mem_string_diff' : different types for formal and actual parameter 2
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4024: 'svn_diff_mem_string_diff' : different types for formal and actual parameter 3
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4024: 'svn_diff_mem_string_output_unified' : different types for formal and actual parameter 6
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> ..\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4024: 'svn_diff_mem_string_output_unified' : different types for formal and actual parameter 7
> Done building target "diff-diff3-test" in project "subversion_vcnet.sln" -- FAILED.
>
> Done building project "subversion_vcnet.sln" -- FAILED.
>
> Build FAILED.
> .\..\..\subversion\libsvn_subr\utf.c(257): warning C4133: 'function' : incompatible types - from 'apr_xlate_t **' to 'win32_xlate_t **'
> .\..\..\subversion\libsvn_subr\utf.c(463): warning C4133: 'function' : incompatible types - from 'apr_xlate_t *' to 'win32_xlate_t *'
> libsvn_subr.def(63): warning LNK4087: CONSTANT keyword is obsolete; use DATA
> c:\svn-builder\djh-xp-vse2005\build\subversion\libsvn_delta\depth_filter_editor.c(83): warning C4715: 'okay_to_edit' : not all control paths return a value
> .\..\..\subversion\libsvn_fs_fs\fs_fs.c(617): warning C4090: 'function' : different 'const' qualifiers
> .\..\..\subversion\libsvn_fs_fs\fs_fs.c(5198): warning C4244: '=' : conversion from 'svn_filesize_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_fs_util\mergeinfo-sqlite-index.c(434): warning C4244: '=' : conversion from 'sqlite_int64' to 'svn_revnum_t', possible loss of data
> .\..\..\subversion\libsvn_fs_util\mergeinfo-sqlite-index.c(435): warning C4244: '=' : conversion from 'sqlite_int64' to 'svn_revnum_t', possible loss of data
> .\..\..\subversion\libsvn_fs_util\mergeinfo-sqlite-index.c(562): warning C4244: 'function' : conversion from 'sqlite_int64' to 'svn_revnum_t', possible loss of data
> .\..\..\subversion\libsvn_fs_util\mergeinfo-sqlite-index.c(670): warning C4244: 'function' : conversion from 'sqlite_int64' to 'svn_revnum_t', possible loss of data
> .\..\..\subversion\libsvn_repos\reporter.c(159): warning C4244: 'function' : conversion from 'apr_uint64_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_repos\reporter.c(160): warning C4244: 'function' : conversion from 'apr_uint64_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_repos\reporter.c(176): warning C4244: '=' : conversion from 'apr_uint64_t' to 'svn_revnum_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_memory.c(115): warning C4018: '>' : signed/unsigned mismatch
> .\..\..\subversion\libsvn_diff\diff_memory.c(127): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_memory.c(160): warning C4244: 'function' : conversion from 'apr_off_t' to 'size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_memory.c(423): warning C4244: '=' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(175): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(189): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(191): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(227): warning C4244: '=' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(280): warning C4244: '=' : conversion from 'apr_off_t' to 'int', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(333): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(345): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(376): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(474): warning C4244: 'function' : conversion from 'apr_off_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(489): warning C4244: 'function' : conversion from 'apr_off_t' to 'size_t', possible loss of data
> .\..\..\subversion\libsvn_diff\diff_file.c(570): warning C4090: 'function' : different 'const' qualifiers
> .\..\..\subversion\libsvn_ra_svn\client.c(392): warning C4090: 'function' : different 'const' qualifiers
> .\..\..\subversion\libsvn_ra_svn\marshal.c(540): warning C4244: '=' : conversion from 'apr_uint64_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_ra_svn\marshal.c(680): warning C4244: '=' : conversion from 'apr_uint64_t' to 'svn_revnum_t', possible loss of data
> .\..\..\subversion\libsvn_ra_svn\marshal.c(845): warning C4244: 'function' : conversion from 'apr_uint64_t' to 'apr_status_t', possible loss of data
> .\..\..\subversion\libsvn_ra_svn\marshal.c(847): warning C4244: '=' : conversion from 'apr_uint64_t' to 'long', possible loss of data
> .\..\..\subversion\libsvn_wc\entries.c(122): warning C4244: '=' : conversion from 'apr_uint64_t' to 'char', possible loss of data
> c:\svn-builder\djh-xp-vse2005\build\subversion\libsvn_wc\translate.c(50): warning C4716: 'read_handler_unsupported' : must return a value
> c:\svn-builder\djh-xp-vse2005\build\subversion\libsvn_wc\translate.c(56): warning C4716: 'write_handler_unsupported' : must return a value
> .\..\..\subversion\libsvn_client\merge.c(1833): warning C4018: '<' : signed/unsigned mismatch
> .\..\..\subversion\libsvn_client\info.c(59): warning C4244: '=' : conversion from 'const svn_filesize_t' to 'apr_size_t', possible loss of data
> .\..\..\subversion\libsvn_client\info.c(98): warning C4244: '=' : conversion from 'const apr_off_t' to 'apr_size_t', possible loss of data
> c:\svn-builder\djh-xp-vse2005\build\subversion\svn\status.c(79): warning C4715: 'generate_status_desc' : not all control paths return a value
> .\..\..\subversion\svnadmin\main.c(88): warning C4042: 'open_fn' : has bad storage class
> .\..\..\subversion\svndumpfilter\main.c(55): warning C4042: 'open_fn' : has bad storage class
> .\..\..\subversion\svnserve\serve.c(1567): warning C4244: '=' : conversion from 'apr_uint64_t' to 'svn_boolean_t', possible loss of data
> .\..\..\subversion\svnserve\serve.c(1572): warning C4244: '=' : conversion from 'apr_uint64_t' to 'svn_boolean_t', possible loss of data
> c:\svn-builder\djh-xp-vse2005\build\subversion\svnserve\serve.c(704): warning C4715: 'kind_word' : not all control paths return a value
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(169): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(169): warning C4024: 'svn_diff_mem_string_diff3' : different types for formal and actual parameter 2
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(169): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(169): warning C4024: 'svn_diff_mem_string_diff3' : different types for formal and actual parameter 3
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(169): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(169): warning C4024: 'svn_diff_mem_string_diff3' : different types for formal and actual parameter 4
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4024: 'svn_diff_mem_string_output_merge' : different types for formal and actual parameter 3
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4024: 'svn_diff_mem_string_output_merge' : different types for formal and actual parameter 4
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(180): warning C4024: 'svn_diff_mem_string_output_merge' : different types for formal and actual parameter 5
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4024: 'svn_diff_mem_string_diff' : different types for formal and actual parameter 2
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(260): warning C4024: 'svn_diff_mem_string_diff' : different types for formal and actual parameter 3
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4024: 'svn_diff_mem_string_output_unified' : different types for formal and actual parameter 6
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4047: 'function' : 'svn_string_t *' differs in levels of indirection from 'int'
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(268): warning C4024: 'svn_diff_mem_string_output_unified' : different types for formal and actual parameter 7
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(164): error C2275: 'svn_string_t' : illegal use of this type as an expression
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(164): error C2065: 'original' : undeclared identifier
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(165): error C2275: 'svn_string_t' : illegal use of this type as an expression
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(165): error C2065: 'modified' : undeclared identifier
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(166): error C2275: 'svn_string_t' : illegal use of this type as an expression
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(166): error C2065: 'latest' : undeclared identifier
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(257): error C2275: 'svn_string_t' : illegal use of this type as an expression
> .\..\..\subversion\tests\libsvn_diff\diff-diff3-test.c(258): error C2275: 'svn_string_t' : illegal use of this type as an expression
> 65 Warning(s)
> 8 Error(s)
>
> Time Elapsed 00:02:28.46
>
> *** Whoops, something choked.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-breakage-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-breakage-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [patch] Add -std=c89 to CFLAGS for gcc
Posted by Eric Gillespie <ep...@google.com>.
Daniel Rall <dl...@finemaltcoding.com> writes:
> How about this patch, then?
>
> [[[
> * configure.in
> (CFLAGS): Add -std=c89 when gcc is detected.
> ]]]
+1 from me. I avoid the problem by using gcc 2.95 (the last good
version! >hide from dannyb<).
> Index: configure.in
> ===================================================================
> --- configure.in (revision 26401)
> +++ configure.in (working copy)
> @@ -25,6 +25,10 @@
> # Look for a C compiler (before anything can set CFLAGS)
> AC_PROG_CC
> +if test "$GCC" = "yes"; then
> + CFLAGS="$CFLAGS -std=c89"
> +fi
> +
> # Look for a C pre-processor
> AC_PROG_CPP
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [patch] Add -std=c89 to CFLAGS for gcc
Posted by Daniel Rall <dl...@collab.net>.
On Thu, 30 Aug 2007, mark benedetto king wrote:
>
> On Thu, Aug 30, 2007 at 03:03:17PM -0700, Daniel Rall wrote:
> >
> > On Aug 14, 2007, at 11:09 AM, Erik Huelsmann wrote:
> >
> > > On 8/14/07, Daniel Rall <dl...@finemaltcoding.com> wrote:
> > >>
> > >> On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
> > >>
> > >>> Quoting Erik Huelsmann <eh...@gmail.com>:
> > >>>
>
> [...]
>
> > >>>>
> > >>>> PS: Is there something in my CFLAGS I can set to prevent this kind
> > >>>> of error?
> > >>>
> > >>> Adding -std=c89 should have that effect.
> > >>
> > >> Is there any particular reason why we don't add this to Makefile by
> > >> default?
> > >
> > > Thanks for asking, because I was wondering the same thing. I think we
> > > should (when we detect GCC, that is).
> >
> > How about this patch, then?
> >
> > [[[
> > * configure.in
> > (CFLAGS): Add -std=c89 when gcc is detected.
> > ]]]
> >
>
> This caused trouble in the past (see r11054).
Thanks Mark. After some research and testing, I've backed out that
change in r27869. It wasn't as helpful as hoped, and as a bonus,
broke the build of the Ruby bindings for me on Linux (FC6).
Re: [patch] Add -std=c89 to CFLAGS for gcc
Posted by mark benedetto king <mb...@lowlatency.com>.
On Thu, Aug 30, 2007 at 03:03:17PM -0700, Daniel Rall wrote:
>
> On Aug 14, 2007, at 11:09 AM, Erik Huelsmann wrote:
>
> > On 8/14/07, Daniel Rall <dl...@finemaltcoding.com> wrote:
> >>
> >> On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
> >>
> >>> Quoting Erik Huelsmann <eh...@gmail.com>:
> >>>
[...]
> >>>>
> >>>> PS: Is there something in my CFLAGS I can set to prevent this kind
> >>>> of error?
> >>>
> >>> Adding -std=c89 should have that effect.
> >>
> >> Is there any particular reason why we don't add this to Makefile by
> >> default?
> >
> > Thanks for asking, because I was wondering the same thing. I think we
> > should (when we detect GCC, that is).
>
> How about this patch, then?
>
> [[[
> * configure.in
> (CFLAGS): Add -std=c89 when gcc is detected.
> ]]]
>
This caused trouble in the past (see r11054).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[patch] Add -std=c89 to CFLAGS for gcc
Posted by Daniel Rall <dl...@finemaltcoding.com>.
On Aug 14, 2007, at 11:09 AM, Erik Huelsmann wrote:
> On 8/14/07, Daniel Rall <dl...@finemaltcoding.com> wrote:
>>
>> On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
>>
>>> Quoting Erik Huelsmann <eh...@gmail.com>:
>>>
>>>> These breakage failures are caused by code-before-declaration
>>>> errors
>>>> on my side; the first in three_way_merge() [line 164], the other in
>>>> two_way_diff() [line 257].
>>>>
>>>> In both cases, the line 'options = options ? options ...' needs
>>>> to be
>>>> moved down below the immediate next block which declares
>>>> svn_string_t*
>>>> variables.
>>>>
>>>> I'm at work, so, if someone could commit this fix, buildbot can
>>>> start
>>>> passing again.
>>>>
>>>> Thanks in advance!
>>>>
>>>> Bye,
>>>>
>>>> Erik.
>>>>
>>>> PS: Is there something in my CFLAGS I can set to prevent this kind
>>>> of error?
>>>
>>> Adding -std=c89 should have that effect.
>>
>> Is there any particular reason why we don't add this to Makefile by
>> default?
>
> Thanks for asking, because I was wondering the same thing. I think we
> should (when we detect GCC, that is).
How about this patch, then?
[[[
* configure.in
(CFLAGS): Add -std=c89 when gcc is detected.
]]]
Index: configure.in
===================================================================
--- configure.in (revision 26401)
+++ configure.in (working copy)
@@ -25,6 +25,10 @@
# Look for a C compiler (before anything can set CFLAGS)
AC_PROG_CC
+if test "$GCC" = "yes"; then
+ CFLAGS="$CFLAGS -std=c89"
+fi
+
# Look for a C pre-processor
AC_PROG_CPP
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r26069: FAIL (win32-xp VS2005)
Posted by Erik Huelsmann <eh...@gmail.com>.
On 8/14/07, Daniel Rall <dl...@finemaltcoding.com> wrote:
>
> On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
>
> > Quoting Erik Huelsmann <eh...@gmail.com>:
> >
> >> These breakage failures are caused by code-before-declaration errors
> >> on my side; the first in three_way_merge() [line 164], the other in
> >> two_way_diff() [line 257].
> >>
> >> In both cases, the line 'options = options ? options ...' needs to be
> >> moved down below the immediate next block which declares
> >> svn_string_t*
> >> variables.
> >>
> >> I'm at work, so, if someone could commit this fix, buildbot can start
> >> passing again.
> >>
> >> Thanks in advance!
> >>
> >> Bye,
> >>
> >> Erik.
> >>
> >> PS: Is there something in my CFLAGS I can set to prevent this kind
> >> of error?
> >
> > Adding -std=c89 should have that effect.
>
> Is there any particular reason why we don't add this to Makefile by
> default?
Thanks for asking, because I was wondering the same thing. I think we
should (when we detect GCC, that is).
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r26069: FAIL (win32-xp VS2005)
Posted by Daniel Rall <dl...@finemaltcoding.com>.
On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
> Quoting Erik Huelsmann <eh...@gmail.com>:
>
>> These breakage failures are caused by code-before-declaration errors
>> on my side; the first in three_way_merge() [line 164], the other in
>> two_way_diff() [line 257].
>>
>> In both cases, the line 'options = options ? options ...' needs to be
>> moved down below the immediate next block which declares
>> svn_string_t*
>> variables.
>>
>> I'm at work, so, if someone could commit this fix, buildbot can start
>> passing again.
>>
>> Thanks in advance!
>>
>> Bye,
>>
>> Erik.
>>
>> PS: Is there something in my CFLAGS I can set to prevent this kind
>> of error?
>
> Adding -std=c89 should have that effect.
Is there any particular reason why we don't add this to Makefile by
default?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r26069: FAIL (win32-xp VS2005)
Posted by Lieven Govaerts <sv...@mobsol.be>.
Quoting Erik Huelsmann <eh...@gmail.com>:
> These breakage failures are caused by code-before-declaration errors
> on my side; the first in three_way_merge() [line 164], the other in
> two_way_diff() [line 257].
>
> In both cases, the line 'options = options ? options ...' needs to be
> moved down below the immediate next block which declares svn_string_t*
> variables.
>
> I'm at work, so, if someone could commit this fix, buildbot can start
> passing again.
>
> Thanks in advance!
>
> Bye,
>
> Erik.
>
> PS: Is there something in my CFLAGS I can set to prevent this kind of error?
Adding -std=c89 should have that effect.
Lieven
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org