You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2007/09/07 20:28:31 UTC
[jira] Commented: (HADOOP-1266) Remove DatanodeDescriptor
dependency from NetworkTopology
[ https://issues.apache.org/jira/browse/HADOOP-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525798 ]
dhruba borthakur commented on HADOOP-1266:
------------------------------------------
+1. Code looks good.
> Remove DatanodeDescriptor dependency from NetworkTopology
> ---------------------------------------------------------
>
> Key: HADOOP-1266
> URL: https://issues.apache.org/jira/browse/HADOOP-1266
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Konstantin Shvachko
> Assignee: Hairong Kuang
> Attachments: GenericTopology.patch
>
>
> NetworkTopology should operate only with the Node interface.
> The actual class DatanodeDescriptor, which implements Node should not be used inside.
> We should avoid introducing unnecessary dependencies.
> This is the typical case when everything can and should be defined using the interface.
> This becomes a requirement if we want to measure distances between other than data-nodes
> types of nodes like TaskTrackers, clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.