You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 19:09:55 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #8449:
[FLINK-12235][hive] Support Hive partition in HiveCatalog
bowenli86 commented on a change in pull request #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog
URL: https://github.com/apache/flink/pull/8449#discussion_r286601953
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -639,8 +640,12 @@ public void createPartition(ObjectPath tablePath, CatalogPartitionSpec partition
checkNotNull(partitionSpec, "CatalogPartitionSpec cannot be null");
checkNotNull(partition, "Partition cannot be null");
+ checkArgument(partition instanceof HiveCatalogPartition, "Currently only supports HiveCatalogPartition");
Review comment:
We currently throw `CatalogException` if the type doesn't match. `checkArgument()` will throw `IllegalArgumentException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services