[GitHub] [incubator-inlong] haibo-duan commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build

[GitBox <gi...@apache.org>]

haibo-duan commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r866111613


##########
inlong-tubemq/tubemq-core/src/main/java/org/apache/inlong/tubemq/corerpc/netty/NettyClientFactory.java:
##########
@@ -235,15 +238,13 @@ private Client createClient(final NodeAddrInfo addressInfo,
                 conf.getInt(RpcConstants.NETTY_WRITE_HIGH_MARK, -1);
         int nettyWriteLowMark =
                 conf.getInt(RpcConstants.NETTY_WRITE_LOW_MARK, -1);
-        if (nettyWriteHighMark > 0) {
-            clientBootstrap.option(ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, nettyWriteHighMark);
-        }
-        if (nettyWriteLowMark > 0) {
-            clientBootstrap.option(ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, nettyWriteLowMark);
+        if (nettyWriteHighMark > 0 && nettyWriteLowMark > 0) {

Review Comment:
   In the previous code,if nettyWriteHighMark not set ,the default value is 64 * 1024. if nettyWriteLowMark not set ,the default value is 32 * 1024. I have modified the code,  please help me review it. thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org