[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

[GitBox <gi...@apache.org>]

cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r644711679



##########
File path: core/src/main/java/kafka/metrics/FilteringJmxReporter.java
##########
@@ -51,7 +50,7 @@ public void updatePredicate(Predicate<MetricName> predicate) {
                 } else {
                     super.onMetricRemoved(name);
                 }
-            }
-            );
+            });
     }
+

Review comment:
       @dongjinleekr The empty lines at the end of the class are still there although you removed the formatting directive. Maybe it is the default behavior. Could you try to add it again and set the value to 0?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org