You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/18 16:42:00 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…

lukecwik commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r426758985



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3539,6 +3539,7 @@ public void onTimer() {}
     @Category({
       ValidatesRunner.class,
       UsesTimersInParDo.class,
+      UsesUnboundedPCollections.class,

Review comment:
       It might be better to follow-up with the PR author as to why they added `.setIsBoundedInternal(IsBounded.UNBOUNDED)` instead of leaving it be bounded and have different variants of runners execute the test (batch/streaming/...)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org