You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2023/08/22 02:29:06 UTC

[GitHub] [cordova-plugin-media] erisu opened a new pull request, #382: feat(android): support Android 13 permission checks and requests

erisu opened a new pull request, #382:
URL: https://github.com/apache/cordova-plugin-media/pull/382

   …
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   android
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Check for and request for permissions based on Android versions.
   
   All Android versions will check for `RECORD_AUDIO` permission. If the permission is not missing (not granted), it will request for permission.
   
   If Android SDK is less then 33, also check for `WRITE_EXTERNAL_STORAGE`. Request for the permission if missing.
   
   Closes #380
   Closes #374
   Resolves #373
   
   ### Description
   <!-- Describe your changes in detail -->
   
   - refactored the `promptForRecord` method
   - removed excessive methods.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   - Created Cordova default project
   - Added plugin.
   - Tested recording functionality.
   - Tested playing the file that was created from the tested recording.
   - Confirmed that the temporary audio file name `tmprecording-<KEY>.3gp` was renamed to the specified filename.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-media] erisu merged pull request #382: feat(android): support Android 13 permission checks and requests

Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #382:
URL: https://github.com/apache/cordova-plugin-media/pull/382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org