[GitHub] [dubbo-go-samples] xavier-niu commented on a change in pull request #230: Rft/add config enhance generic dubbo

[GitBox <gi...@apache.org>]

xavier-niu commented on a change in pull request #230:
URL: https://github.com/apache/dubbo-go-samples/pull/230#discussion_r703972620



##########
File path: generic/README.md
##########
@@ -4,61 +4,39 @@ Generic invocation is mainly used when the client does not have API interface or
 
 ## Getting Started
 
-You should provide the information of config for both provider and consumer, in this case, we use `default` directory as an example.
+### Instructions
 
-```shell
-export CONF_PROVIDER_FILE_PATH="$(pwd)/default/go-server/conf/server.yml"
-export CONF_CONSUMER_FILE_PATH="$(pwd)/default/go-client/conf/client.yml"
-```
+1. Start zookeeper
 
-ZooKeeper is required as well, you could launch it using docker-compose.
+   ```shell
+   cd ./default/go-server/docker \
+     && docker-compose up -d
+   ```
 
-```shell
-cd ./default/go-server/docker \
-  && docker-compose up -d
-```
+2. Start the server to run provider.
 
-### Map: Default Way
+   1. go
 
-The case for map is at `default` directory. Launch the provider by the following code.
+      Use goland to start generic-dubbo-go-server

Review comment:
       Please update the name of run.xml and README.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org