You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/27 15:57:32 UTC

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

donnerpeter opened a new pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253


   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Turkish `I`s don't work with `LANG tr`
   
   # Solution
   
   Support `tr` as well as `tr_TR`
   
   # Tests
   
   `dotless_i` from Hunspell/C++
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`.
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566653084



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -370,7 +370,7 @@ private void readAffixFile(InputStream affixStream, CharsetDecoder decoder)
         fullStrip = true;
       } else if ("LANG".equals(firstWord)) {
         language = singleArgument(reader, line);
-        alternateCasing = "tr_TR".equals(language) || "az_AZ".equals(language);

Review comment:
       Locale reflects what those iso codes are in the wild... That's why I'm a bit uneasy about using a simple prefix... It should at least be something like this: language.equalsIgnoreCase("tr") || language.toLowerCase(Locale.ROOT).startsWith("tr_")




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] donnerpeter commented on pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#issuecomment-769650662


   Force-pushed to resolve a conflict in `SpellCheckerTest.java`, other files haven't changed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566664122



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -370,7 +370,7 @@ private void readAffixFile(InputStream affixStream, CharsetDecoder decoder)
         fullStrip = true;
       } else if ("LANG".equals(firstWord)) {
         language = singleArgument(reader, line);
-        alternateCasing = "tr_TR".equals(language) || "az_AZ".equals(language);

Review comment:
       I looked at that too - surprising there isn't iso -> locale conversion built-in. Sorry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss merged pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566629532



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -370,7 +370,7 @@ private void readAffixFile(InputStream affixStream, CharsetDecoder decoder)
         fullStrip = true;
       } else if ("LANG".equals(firstWord)) {
         language = singleArgument(reader, line);
-        alternateCasing = "tr_TR".equals(language) || "az_AZ".equals(language);

Review comment:
       Hmm... I didn't check but can we use Locale to parse it properly to extract the language from country variant? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566662702



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -370,7 +370,7 @@ private void readAffixFile(InputStream affixStream, CharsetDecoder decoder)
         fullStrip = true;
       } else if ("LANG".equals(firstWord)) {
         language = singleArgument(reader, line);
-        alternateCasing = "tr_TR".equals(language) || "az_AZ".equals(language);

Review comment:
       Good point. So it seems that some parsing is inevitable, and quick googling shows that JDK doesn't seem to have that parsing. So I'll split by '_' myself.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566643599



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -370,7 +370,7 @@ private void readAffixFile(InputStream affixStream, CharsetDecoder decoder)
         fullStrip = true;
       } else if ("LANG".equals(firstWord)) {
         language = singleArgument(reader, line);
-        alternateCasing = "tr_TR".equals(language) || "az_AZ".equals(language);

Review comment:
       Probably we can, but `Locale`s javadoc is so scary and the class looks so general that I'd prefer this simple code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org