You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sirona.apache.org by "E. Vernat (JIRA)" <ji...@apache.org> on 2014/04/21 15:28:14 UTC

[jira] [Created] (SIRONA-36) Display GWT-RPC method names

E. Vernat created SIRONA-36:
-------------------------------

             Summary: Display GWT-RPC method names
                 Key: SIRONA-36
                 URL: https://issues.apache.org/jira/browse/SIRONA-36
             Project: Sirona
          Issue Type: New Feature
            Reporter: E. Vernat


I suggest displaying the GWT-RPC method names from http requests in the statistics.
The GWT-RPC method name can be found in an http request by scanning the payload.

To do that, a request wrapper could be added in a servlet filter, for example in the servlet filter of the web agent: http://svn.apache.org/repos/asf/incubator/sirona/trunk/agent/performance/web/src/main/java/org/apache/sirona/web/servlet/SironaFilter.java

This request wrapper could be inspired or copied from the [JavaMelody|https://javamelody.googlecode.com] one doing that: https://code.google.com/p/javamelody/source/browse/trunk/javamelody-core/src/main/java/net/bull/javamelody/PayloadNameRequestWrapper.java

Then, in the doFilter method of the servlet filter, it could be something like:
{code}
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
	HttpServletRequest httpRequest = (HttpServletRequest) request;

	final PayloadNameRequestWrapper payloadNameRequestWrapper = new PayloadNameRequestWrapper(httpRequest);
	payloadNameRequestWrapper.initialize();
	if (payloadNameRequestWrapper.getPayloadRequestType() != null) {
		chain.doFilter(payloadNameRequestWrapper, response);
		final String methodNameAndType = payloadNameRequestWrapper.getPayloadRequestName() + ' ' + payloadNameRequestWrapper.getPayloadRequestType();
		// TODO record event for methodNameAndType
	} else {
		chain.doFilter(request, response);
	}
}
{code}

I don’t know exactly how to record and display that GWT-RPC method name in Sirona, so that’s still a work up to the project. But given that http requests for GWT-RPC often have a generic name, that GWT-RPC method name may be good if displayed not far from (or with) those http requests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)