You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org> on 2012/01/19 11:19:40 UTC
[jira] [Commented] (LUCENE-3707) Add a Lucene3x private
SegmentInfosFormat implemenation
[ https://issues.apache.org/jira/browse/LUCENE-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189040#comment-13189040 ]
Uwe Schindler commented on LUCENE-3707:
---------------------------------------
Cool! I will send my +1 once I tested and reviewed.
One thing:
{code}
+ assert format <= SegmentInfos.FORMAT_4_0;
{code}
In my opinion, this should be a hard IndexFormatTooOldException (which is correct for someone who removed 3.x codec from his classpath). It *should* not happen, but for everything that comes from "untrusted" files on disk we should hard check those things. Otherwise maybe someone has a very strange codec configuration that enforces the 4.0 codec to read old indexes and does serious harm :-) This also makes migration to Lucene 5.0 easier. We have the version check already available, only 3.x codec needs to be removed and we are done.
This check also costs nothing, so we should *always ever* use hard checks when we read values from files, to detect errors early (of course, if it's to heavy we can use asserts).
> Add a Lucene3x private SegmentInfosFormat implemenation
> -------------------------------------------------------
>
> Key: LUCENE-3707
> URL: https://issues.apache.org/jira/browse/LUCENE-3707
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Blocker
> Fix For: 4.0
>
> Attachments: LUCENE-3707.patch
>
>
> we still don't have a Lucene3x & preflex version of segment infos format. we need this before we release 4.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org