You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/06/08 23:13:56 UTC

Review Request: Removed String instantiation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11751/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

String instantiation and redundant method call replaced with a constant.


Diffs
-----

  core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 

Diff: https://reviews.apache.org/r/11751/diff/


Testing
-------


Thanks,

Laszlo Hornyak


Re: Review Request: Removed String instantiation

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11751/#review21996
-----------------------------------------------------------

Ship it!


Applied to master: ce8ada030d3150087357d7135c3877c25a4702c2

Thanks for the patch!

- Chip Childers


On June 8, 2013, 9:13 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11751/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 9:13 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> String instantiation and redundant method call replaced with a constant.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a 
> 
> Diff: https://reviews.apache.org/r/11751/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>