You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "StandByStormMetaMaster (via GitHub)" <gi...@apache.org> on 2024/06/13 13:59:55 UTC
[PR] Supress the login credentials during pod start-up [activemq-artemis]
StandByStormMetaMaster opened a new pull request, #4975:
URL: https://github.com/apache/activemq-artemis/pull/4975
For troubleshooting the output of our pods are fed to kibana. People analyzing these logs should not have the ability to see these credentials hence the proposal to add a SUPPRESS_CREDENTIALS environment variable to suppress this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Supress the login credentials during pod start-up [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4975:
URL: https://github.com/apache/activemq-artemis/pull/4975#discussion_r1638322834
##########
artemis-docker/docker-run.sh:
##########
@@ -33,7 +33,11 @@ fi
if ! [ -f ./etc/broker.xml ]; then
CREATE_ARGUMENTS="--user ${ARTEMIS_USER} --password ${ARTEMIS_PASSWORD} --silent ${LOGIN_OPTION} ${EXTRA_ARGS}"
- echo CREATE_ARGUMENTS=${CREATE_ARGUMENTS}
+ if [[ ${SUPPRESS_CREDENTIALS,,} == "true" ]]; then
+ echo CREATE_ARGUMENTS="--user XXXXX --password XXXXX --silent ${LOGIN_OPTION} ${EXTRA_ARGS}"
Review Comment:
wouldn't be simpler to just not echo CREATE_ARGUMENTS?
just open a JIRA, and remove this line... no need to print that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Supress the login credentials during pod start-up [activemq-artemis]
Posted by "StandByStormMetaMaster (via GitHub)" <gi...@apache.org>.
StandByStormMetaMaster closed pull request #4975: Supress the login credentials during pod start-up
URL: https://github.com/apache/activemq-artemis/pull/4975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Supress the login credentials during pod start-up [activemq-artemis]
Posted by "StandByStormMetaMaster (via GitHub)" <gi...@apache.org>.
StandByStormMetaMaster commented on code in PR #4975:
URL: https://github.com/apache/activemq-artemis/pull/4975#discussion_r1638354790
##########
artemis-docker/docker-run.sh:
##########
@@ -33,7 +33,11 @@ fi
if ! [ -f ./etc/broker.xml ]; then
CREATE_ARGUMENTS="--user ${ARTEMIS_USER} --password ${ARTEMIS_PASSWORD} --silent ${LOGIN_OPTION} ${EXTRA_ARGS}"
- echo CREATE_ARGUMENTS=${CREATE_ARGUMENTS}
+ if [[ ${SUPPRESS_CREDENTIALS,,} == "true" ]]; then
+ echo CREATE_ARGUMENTS="--user XXXXX --password XXXXX --silent ${LOGIN_OPTION} ${EXTRA_ARGS}"
Review Comment:
Yes, it would 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact