You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2011/09/13 16:03:09 UTC

[jira] [Created] (HBASE-4385) Use CacheBuilder in place of MapMaker

Use CacheBuilder in place of MapMaker
-------------------------------------

                 Key: HBASE-4385
                 URL: https://issues.apache.org/jira/browse/HBASE-4385
             Project: HBase
          Issue Type: Task
            Reporter: Ted Yu


Guava release 10 introduced CacheBuilder.
We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118538#comment-13118538 ] 

Li Pi commented on HBASE-4385:
------------------------------

Peeked through it - you do something weird with cachebuilder. I'll
think of the rest of this later.

On Fri, Sep 30, 2011 at 3:29 PM, Ted Yu (Issue Comment Edited) (JIRA)

                
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>         Attachments: 4385.txt
>
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4385:
--------------------------

    Attachment: 4385.txt

Here is unfinished work, just for reference.
                
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>         Attachments: 4385.txt
>
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118494#comment-13118494 ] 

Ted Yu edited comment on HBASE-4385 at 9/30/11 10:29 PM:
---------------------------------------------------------

Guava 10.0 doesn't support Cache.asMap().put()
We need to wait for 10.1 or 11.0
                
      was (Author: yuzhihong@gmail.com):
    Guava 10.0 doesn't support Cache.put()
We need to wait for 10.1 or 11.0
                  
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>         Attachments: 4385.txt
>
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118494#comment-13118494 ] 

Ted Yu commented on HBASE-4385:
-------------------------------

Guava 10.0 doesn't support Cache.put()
We need to wait for 10.1 or 11.0
                
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>         Attachments: 4385.txt
>
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117422#comment-13117422 ] 

Li Pi commented on HBASE-4385:
------------------------------

The removallistener vs evictionlistener gets rid of a possible source
of race conditions, I wanted to use cachebuilder initially, but it
wasn't available.


                
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117411#comment-13117411 ] 

Ted Yu commented on HBASE-4385:
-------------------------------

Since guava r10 has been released, I tried to create a patch by using CacheBuilder last night.
It turned out that r10 supports the transition from ComputingMap at the moment.

Our use case isn't supported yet.
I will revisit this when proper support is added in future guava release.
                
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4385) Use CacheBuilder in place of MapMaker

Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117417#comment-13117417 ] 

Li Pi commented on HBASE-4385:
------------------------------

Awesome! I can take care of it. The evictionlistener of CacheBuilder
is slightly different.

On Thu, Sep 29, 2011 at 9:36 AM, Ted Yu (Commented) (JIRA)

                
> Use CacheBuilder in place of MapMaker
> -------------------------------------
>
>                 Key: HBASE-4385
>                 URL: https://issues.apache.org/jira/browse/HBASE-4385
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>
> Guava release 10 introduced CacheBuilder.
> We should use it in place of MapMaker which is used for caching.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira