Re: [PR] Add new compaction config and status APIs served by the Overlord (druid)

["github-advanced-security[bot] (via GitHub)" <gi...@apache.org>]

github-advanced-security[bot] commented on code in PR #17834:
URL: https://github.com/apache/druid/pull/17834#discussion_r2020152935


##########
server/src/test/java/org/apache/druid/server/http/CoordinatorCompactionConfigsResourceTest.java:
##########
@@ -109,32 +108,15 @@
     Assert.assertEquals(CompactionEngine.NATIVE, defaultConfig.getEngine());
   }
 
-  @Test
-  public void testUpdateClusterConfig()
-  {
-    Response response = resource.updateClusterCompactionConfig(
-        new ClusterCompactionConfig(0.5, 10, null, true, CompactionEngine.MSQ),
-        mockHttpServletRequest
-    );
-    verifyStatus(Response.Status.OK, response);
-
-    final DruidCompactionConfig updatedConfig = verifyAndGetPayload(
-        resource.getCompactionConfig(),
-        DruidCompactionConfig.class
-    );
-
-    Assert.assertNotNull(updatedConfig);
-    Assert.assertEquals(0.5, updatedConfig.getCompactionTaskSlotRatio(), DELTA);
-    Assert.assertEquals(10, updatedConfig.getMaxCompactionTaskSlots());
-    Assert.assertTrue(updatedConfig.isUseSupervisors());
-    Assert.assertEquals(CompactionEngine.MSQ, updatedConfig.getEngine());
-  }
-
   @Test
   public void testSetCompactionTaskLimit()
   {
-    final DruidCompactionConfig defaultConfig
+    resource.setCompactionTaskLimit(0.1, 100, mockHttpServletRequest);

Review Comment:
   ## Deprecated method or constructor invocation
   
   Invoking [CoordinatorCompactionConfigsResource.setCompactionTaskLimit](1) should be avoided because it has been deprecated.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/8776)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org