[GitHub] [spark] squito commented on a change in pull request #24057: [SPARK-26839][WIP][SQL] Work around classloader changes in Java 9 for Hive isolation

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #24057: [SPARK-26839][WIP][SQL] Work around classloader changes in Java 9 for Hive isolation
URL: https://github.com/apache/spark/pull/24057#discussion_r264306118
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
 ##########
 @@ -191,8 +187,8 @@ private[hive] class IsolatedClientLoader(
     (sharesHadoopClasses && isHadoopClass) ||
     name.startsWith("scala.") ||
     (name.startsWith("com.google") && !name.startsWith("com.google.cloud")) ||
-    name.startsWith("java.lang.") ||
-    name.startsWith("java.net") ||
+    name.startsWith("java.") ||
+    name.startsWith("javax.") ||
 
 Review comment:
   yes I found the same, this seems like a mistake.  I also noticed that I needed to add at least
   
   ```
       // needed for at least com.sun.security.auth.module.UnixLoginModule
       name.startsWith("com.sun") ||
   ```
   
   When I ran some tests w/ security.  I wondered whether I should make that rule even tighter, but I figured everything under com.sun is probably considered shared.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org