You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/04 13:06:33 UTC
[GitHub] flink pull request #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunc...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3824
[FLINK-6164] Make ProcessWindowFunction a RichFunction
This PR modifies the ProcessWindowFunction and ProcessAllWindowFunction classes to extend AbstractRichtFunction.
The existing Rich* versions were deprecated, and all usages of them replaced.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6164_rich_process
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3824
----
commit 7991d4d4f2963fe5e60a9ccca5a606b41b97c962
Author: zentol <ch...@apache.org>
Date: 2017-05-03T13:57:05Z
[FLINK-6164] Make ProcessWindowFunction a RichFunction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunc...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3824#discussion_r114771179
--- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/function/ProcessAllWindowFunction.scala ---
@@ -35,7 +35,9 @@ import org.apache.flink.util.Collector
* @tparam W The type of the window.
*/
@PublicEvolving
-abstract class ProcessAllWindowFunction[IN, OUT, W <: Window] extends Function with Serializable {
+abstract class ProcessAllWindowFunction[IN, OUT, W <: Window]
--- End diff --
I think the `Serializable` is not needed here. (Was there before, so not introduced in this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunction
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3824
I've removed Serializable, adjusted the `@Deprecated` annotations like in #3816 and fixed the unused imports (there were also some in `ProcessAllWindowFunction.scala`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunc...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3824#discussion_r114771220
--- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/function/ProcessWindowFunction.scala ---
@@ -36,7 +36,10 @@ import org.apache.flink.util.Collector
* @tparam W The type of the window.
*/
@PublicEvolving
-abstract class ProcessWindowFunction[IN, OUT, KEY, W <: Window] extends Function with Serializable {
+abstract class ProcessWindowFunction[IN, OUT, KEY, W <: Window]
--- End diff --
See above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunction
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3824
Ha! I didn't think of the annotations.
This looks good to merge now!
Thanks for fixing these so quickly! 😃
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3824
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunc...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3824#discussion_r114772035
--- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/AccumulatingAlignedProcessingTimeWindowOperatorTest.java ---
@@ -1038,7 +1038,7 @@ private void assertInvalidParameter(long windowSize, long windowSlide) {
// ------------------------------------------------------------------------
- private static class StatefulFunction extends RichProcessWindowFunction<Integer, Integer, Integer, TimeWindow> {
+ private static class StatefulFunction extends ProcessWindowFunction<Integer, Integer, Integer, TimeWindow> {
--- End diff --
With this we add two unused imports.
And yes, I don't like that we don't have checkstyle active on the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3824: [FLINK-6164] Make ProcessWindowFunction a RichFunction
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3824
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---