You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2013/08/28 22:52:24 UTC
git commit: Support Integer.MAX_VALUE size PUTs
Updated Branches:
refs/heads/master 607b178c6 -> 5261f760b
Support Integer.MAX_VALUE size PUTs
Previously jclouds enforced Integer.MAX_VALUE - 1 size. Tested
against Atmos Online.
Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/commit/5261f760
Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/tree/5261f760
Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/diff/5261f760
Branch: refs/heads/master
Commit: 5261f760b79187003c41540885cf7b171b965552
Parents: 607b178
Author: Andrew Gaul <ga...@apache.org>
Authored: Wed Aug 28 11:58:02 2013 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Wed Aug 28 13:52:06 2013 -0700
----------------------------------------------------------------------
.../http/internal/JavaUrlHttpCommandExecutorService.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/5261f760/core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java b/core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
index acc2041..fac7c55 100644
--- a/core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
+++ b/core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
@@ -209,9 +209,11 @@ public class JavaUrlHttpCommandExecutorService extends BaseHttpCommandExecutorSe
writePayloadToConnection(payload, "streaming", connection);
} else {
Long length = checkNotNull(md.getContentLength(), "payload.getContentLength");
- // http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6755625
- checkArgument(length < Integer.MAX_VALUE,
- "JDK 1.6 does not support >2GB chunks. Use chunked encoding, if possible.");
+ // TODO: remove check after moving to JDK 7.
+ checkArgument(length <= Integer.MAX_VALUE,
+ "Cannot transfer 2 GB or larger chunks due to JDK 1.6 limitations." +
+ " Use chunked encoding or multi-part upload, if possible." +
+ " For more information: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6755625");
if (length > 0) {
connection.setRequestProperty(CONTENT_LENGTH, length.toString());
connection.setFixedLengthStreamingMode(length.intValue());