You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Subhrat Chaudhary via Review Board <no...@reviews.apache.org> on 2023/10/02 14:51:59 UTC
Review Request 74634: RANGER-4446: Need an API to return dataset summary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74634/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: https://issues.apache.org/jira/browse/RANGER-4446
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4446
Repository: ranger
Description
-------
We need additional details in the response for DatasetHeaderInfo like summary for DataShare included int he dataset.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java a1c883356
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java ce4769569
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 56b908625
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java b22208773
security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java eadbb9228
Diff: https://reviews.apache.org/r/74634/diff/1/
Testing
-------
Updated dataset summary details:
{
"id": 1,
"guid": "35081b85-7c1e-48b7-aca4-f7c7b9aa7b18",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696075254523,
"updateTime": 1696075254534,
"version": 1,
"name": "DS1",
"principalsCountByType": {
"USER": 2,
"GROUP": 0,
"ROLE": 0
},
"projectsCount": 0,
"permissionForCaller": "ADMIN",
"totalResourceCount": 2,
"dataShares": [
{
"id": 3,
"guid": "b2c938ac-8da7-4861-a29a-cfed5bdb62c8",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696073077134,
"updateTime": 1696073077136,
"version": 1,
"name": "datashare3",
"serviceId": 1,
"serviceName": "hive1",
"zoneId": 2,
"zoneName": "zone1",
"resourceCount": 1,
"shareStatus": "REQUESTED"
},
{
"id": 4,
"guid": "bf92da3b-3a4b-445f-8fa0-11f5a02306f3",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696146862432,
"updateTime": 1696146862447,
"version": 1,
"name": "datashare4",
"serviceId": 1,
"serviceName": "hive1",
"zoneId": 2,
"zoneName": "zone1",
"resourceCount": 1,
"shareStatus": "REQUESTED"
}
]
}
Thanks,
Subhrat Chaudhary
Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74634/#review225828
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 4, 2023, 1:46 p.m., Subhrat Chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74634/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2023, 1:46 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: https://issues.apache.org/jira/browse/RANGER-4446
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4446
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We need additional details in the response for DatasetHeaderInfo like summary for DataShare included int he dataset.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java fd27f54a9
> security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 42a2fa16c
> security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java b7ef9b86a
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java dede14dfd
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java eadbb9228
>
>
> Diff: https://reviews.apache.org/r/74634/diff/3/
>
>
> Testing
> -------
>
> Updated dataset summary details:
> {
> "id": 1,
> "guid": "35081b85-7c1e-48b7-aca4-f7c7b9aa7b18",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696075254523,
> "updateTime": 1696075254534,
> "version": 1,
> "name": "DS1",
> "principalsCountByType": {
> "USER": 2,
> "GROUP": 0,
> "ROLE": 0
> },
> "projectsCount": 0,
> "permissionForCaller": "ADMIN",
> "totalResourceCount": 2,
> "dataShares": [
> {
> "id": 3,
> "guid": "b2c938ac-8da7-4861-a29a-cfed5bdb62c8",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696073077134,
> "updateTime": 1696073077136,
> "version": 1,
> "name": "datashare3",
> "serviceId": 1,
> "serviceName": "hive1",
> "zoneId": 2,
> "zoneName": "zone1",
> "resourceCount": 1,
> "shareStatus": "REQUESTED"
> },
> {
> "id": 4,
> "guid": "bf92da3b-3a4b-445f-8fa0-11f5a02306f3",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696146862432,
> "updateTime": 1696146862447,
> "version": 1,
> "name": "datashare4",
> "serviceId": 1,
> "serviceName": "hive1",
> "zoneId": 2,
> "zoneName": "zone1",
> "resourceCount": 1,
> "shareStatus": "REQUESTED"
> }
> ]
> }
>
>
> Thanks,
>
> Subhrat Chaudhary
>
>
Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary
Posted by Subhrat Chaudhary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74634/
-----------------------------------------------------------
(Updated Oct. 4, 2023, 7:16 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Resolved conflicts
Bugs: https://issues.apache.org/jira/browse/RANGER-4446
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4446
Repository: ranger
Description
-------
We need additional details in the response for DatasetHeaderInfo like summary for DataShare included int he dataset.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java fd27f54a9
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 42a2fa16c
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java b7ef9b86a
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java dede14dfd
security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java eadbb9228
Diff: https://reviews.apache.org/r/74634/diff/3/
Changes: https://reviews.apache.org/r/74634/diff/2-3/
Testing
-------
Updated dataset summary details:
{
"id": 1,
"guid": "35081b85-7c1e-48b7-aca4-f7c7b9aa7b18",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696075254523,
"updateTime": 1696075254534,
"version": 1,
"name": "DS1",
"principalsCountByType": {
"USER": 2,
"GROUP": 0,
"ROLE": 0
},
"projectsCount": 0,
"permissionForCaller": "ADMIN",
"totalResourceCount": 2,
"dataShares": [
{
"id": 3,
"guid": "b2c938ac-8da7-4861-a29a-cfed5bdb62c8",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696073077134,
"updateTime": 1696073077136,
"version": 1,
"name": "datashare3",
"serviceId": 1,
"serviceName": "hive1",
"zoneId": 2,
"zoneName": "zone1",
"resourceCount": 1,
"shareStatus": "REQUESTED"
},
{
"id": 4,
"guid": "bf92da3b-3a4b-445f-8fa0-11f5a02306f3",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696146862432,
"updateTime": 1696146862447,
"version": 1,
"name": "datashare4",
"serviceId": 1,
"serviceName": "hive1",
"zoneId": 2,
"zoneName": "zone1",
"resourceCount": 1,
"shareStatus": "REQUESTED"
}
]
}
Thanks,
Subhrat Chaudhary
Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary
Posted by Subhrat Chaudhary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74634/
-----------------------------------------------------------
(Updated Oct. 3, 2023, 2:40 p.m.)
Review request for ranger and Madhan Neethiraj.
Bugs: https://issues.apache.org/jira/browse/RANGER-4446
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4446
Repository: ranger
Description
-------
We need additional details in the response for DatasetHeaderInfo like summary for DataShare included int he dataset.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java fd27f54a9
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 05705cd92
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java f827c754d
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java b22208773
security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java eadbb9228
Diff: https://reviews.apache.org/r/74634/diff/2/
Changes: https://reviews.apache.org/r/74634/diff/1-2/
Testing
-------
Updated dataset summary details:
{
"id": 1,
"guid": "35081b85-7c1e-48b7-aca4-f7c7b9aa7b18",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696075254523,
"updateTime": 1696075254534,
"version": 1,
"name": "DS1",
"principalsCountByType": {
"USER": 2,
"GROUP": 0,
"ROLE": 0
},
"projectsCount": 0,
"permissionForCaller": "ADMIN",
"totalResourceCount": 2,
"dataShares": [
{
"id": 3,
"guid": "b2c938ac-8da7-4861-a29a-cfed5bdb62c8",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696073077134,
"updateTime": 1696073077136,
"version": 1,
"name": "datashare3",
"serviceId": 1,
"serviceName": "hive1",
"zoneId": 2,
"zoneName": "zone1",
"resourceCount": 1,
"shareStatus": "REQUESTED"
},
{
"id": 4,
"guid": "bf92da3b-3a4b-445f-8fa0-11f5a02306f3",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1696146862432,
"updateTime": 1696146862447,
"version": 1,
"name": "datashare4",
"serviceId": 1,
"serviceName": "hive1",
"zoneId": 2,
"zoneName": "zone1",
"resourceCount": 1,
"shareStatus": "REQUESTED"
}
]
}
Thanks,
Subhrat Chaudhary
Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary
Posted by Subhrat Chaudhary via Review Board <no...@reviews.apache.org>.
> On Oct. 3, 2023, 12:09 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
> > Lines 480 (patched)
> > <https://reviews.apache.org/r/74634/diff/1/?file=2280582#file2280582line480>
> >
> > Consider using GdsPermission for permissionForCaller, instead of String.
Using GdsPermission for permissionForCaller
> On Oct. 3, 2023, 12:09 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
> > Lines 540 (patched)
> > <https://reviews.apache.org/r/74634/diff/1/?file=2280582#file2280582line540>
> >
> > Field id is present in base class RangerBaseModelObject. Please review and remove from DataShareInDatasetSummary.
Removed id from DataShareInDatasetSummary.
> On Oct. 3, 2023, 12:09 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
> > Lines 547 (patched)
> > <https://reviews.apache.org/r/74634/diff/1/?file=2280582#file2280582line547>
> >
> > Consider using GdsShareStatus for shareStatus, instead of String.
Using GdsShareStatus for shareStatus
> On Oct. 3, 2023, 12:09 a.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java
> > Line 135 (original), 143 (patched)
> > <https://reviews.apache.org/r/74634/diff/1/?file=2280583#file2280583line143>
> >
> > getDatasetHeaders() => getDatasetSummary()
Updated logs for the method getDatasetSummary
> On Oct. 3, 2023, 12:09 a.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java
> > Line 251 (original), 251 (patched)
> > <https://reviews.apache.org/r/74634/diff/1/?file=2280586#file2280586line251>
> >
> > resource-count in a dataShare shouldn't vary across datasets it is associated to. If yes, does this method need datasetId parameter?
removed datasetId from signature and renamed method to getResourceCountForDataShare
- Subhrat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74634/#review225806
-----------------------------------------------------------
On Oct. 3, 2023, 2:40 p.m., Subhrat Chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74634/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2023, 2:40 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: https://issues.apache.org/jira/browse/RANGER-4446
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4446
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We need additional details in the response for DatasetHeaderInfo like summary for DataShare included int he dataset.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java fd27f54a9
> security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 05705cd92
> security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java f827c754d
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java b22208773
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java eadbb9228
>
>
> Diff: https://reviews.apache.org/r/74634/diff/2/
>
>
> Testing
> -------
>
> Updated dataset summary details:
> {
> "id": 1,
> "guid": "35081b85-7c1e-48b7-aca4-f7c7b9aa7b18",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696075254523,
> "updateTime": 1696075254534,
> "version": 1,
> "name": "DS1",
> "principalsCountByType": {
> "USER": 2,
> "GROUP": 0,
> "ROLE": 0
> },
> "projectsCount": 0,
> "permissionForCaller": "ADMIN",
> "totalResourceCount": 2,
> "dataShares": [
> {
> "id": 3,
> "guid": "b2c938ac-8da7-4861-a29a-cfed5bdb62c8",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696073077134,
> "updateTime": 1696073077136,
> "version": 1,
> "name": "datashare3",
> "serviceId": 1,
> "serviceName": "hive1",
> "zoneId": 2,
> "zoneName": "zone1",
> "resourceCount": 1,
> "shareStatus": "REQUESTED"
> },
> {
> "id": 4,
> "guid": "bf92da3b-3a4b-445f-8fa0-11f5a02306f3",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696146862432,
> "updateTime": 1696146862447,
> "version": 1,
> "name": "datashare4",
> "serviceId": 1,
> "serviceName": "hive1",
> "zoneId": 2,
> "zoneName": "zone1",
> "resourceCount": 1,
> "shareStatus": "REQUESTED"
> }
> ]
> }
>
>
> Thanks,
>
> Subhrat Chaudhary
>
>
Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74634/#review225806
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
Lines 480 (patched)
<https://reviews.apache.org/r/74634/#comment314245>
Consider using GdsPermission for permissionForCaller, instead of String.
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
Lines 540 (patched)
<https://reviews.apache.org/r/74634/#comment314241>
Field id is present in base class RangerBaseModelObject. Please review and remove from DataShareInDatasetSummary.
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
Lines 547 (patched)
<https://reviews.apache.org/r/74634/#comment314242>
Consider using GdsShareStatus for shareStatus, instead of String.
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java
Line 135 (original), 143 (patched)
<https://reviews.apache.org/r/74634/#comment314244>
getDatasetHeaders() => getDatasetSummary()
security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java
Line 251 (original), 251 (patched)
<https://reviews.apache.org/r/74634/#comment314243>
resource-count in a dataShare shouldn't vary across datasets it is associated to. If yes, does this method need datasetId parameter?
- Madhan Neethiraj
On Oct. 2, 2023, 2:51 p.m., Subhrat Chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74634/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2023, 2:51 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: https://issues.apache.org/jira/browse/RANGER-4446
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4446
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We need additional details in the response for DatasetHeaderInfo like summary for DataShare included int he dataset.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java a1c883356
> security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java ce4769569
> security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 56b908625
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java b22208773
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java eadbb9228
>
>
> Diff: https://reviews.apache.org/r/74634/diff/1/
>
>
> Testing
> -------
>
> Updated dataset summary details:
> {
> "id": 1,
> "guid": "35081b85-7c1e-48b7-aca4-f7c7b9aa7b18",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696075254523,
> "updateTime": 1696075254534,
> "version": 1,
> "name": "DS1",
> "principalsCountByType": {
> "USER": 2,
> "GROUP": 0,
> "ROLE": 0
> },
> "projectsCount": 0,
> "permissionForCaller": "ADMIN",
> "totalResourceCount": 2,
> "dataShares": [
> {
> "id": 3,
> "guid": "b2c938ac-8da7-4861-a29a-cfed5bdb62c8",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696073077134,
> "updateTime": 1696073077136,
> "version": 1,
> "name": "datashare3",
> "serviceId": 1,
> "serviceName": "hive1",
> "zoneId": 2,
> "zoneName": "zone1",
> "resourceCount": 1,
> "shareStatus": "REQUESTED"
> },
> {
> "id": 4,
> "guid": "bf92da3b-3a4b-445f-8fa0-11f5a02306f3",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1696146862432,
> "updateTime": 1696146862447,
> "version": 1,
> "name": "datashare4",
> "serviceId": 1,
> "serviceName": "hive1",
> "zoneId": 2,
> "zoneName": "zone1",
> "resourceCount": 1,
> "shareStatus": "REQUESTED"
> }
> ]
> }
>
>
> Thanks,
>
> Subhrat Chaudhary
>
>