[GitHub] [flink] zhuzhurk commented on a diff in pull request #20080: [FLINK-28258] Introduce ExecutionHistory to host historical executions for each execution vertex

[GitBox <gi...@apache.org>]

zhuzhurk commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907288015


##########
flink-tests/src/test/java/org/apache/flink/test/runtime/DefaultSchedulerLocalRecoveryITCase.java:
##########
@@ -90,7 +90,9 @@ private void assertNonLocalRecoveredTasksEquals(ArchivedExecutionGraph graph, in
                 continue;
             }
             AllocationID priorAllocation =
-                    vertex.getPriorExecutionAttempt(currentAttemptNumber - 1)
+                    vertex.getExecutionHistory()
+                            .getHistoricalExecution(currentAttemptNumber - 1)
+                            .get()
                             .getAssignedAllocationID();

Review Comment:
   In my understanding, it's fine for tests. If NPE happens, it should be a production problem and I prefer to expose it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org