You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2017/01/13 13:40:38 UTC

[Bug 60584] New: NPE with missing Drawing in XSSFReader

https://bz.apache.org/bugzilla/show_bug.cgi?id=60584

            Bug ID: 60584
           Summary: NPE with missing Drawing in XSSFReader
           Product: POI
           Version: 3.16-dev
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: tallison@mitre.org
  Target Milestone: ---

On TIKA-2134, Seva Alekseyev submitted an example xlsx file that triggers an
NPE when a shape is missing from the file.

Excel appears to silently ignore shape relationships that don't include the
file.  

Caused by: java.lang.NullPointerException
        at
org.apache.poi.xssf.usermodel.XSSFDrawing.<init>(XSSFDrawing.java:89)
        at
org.apache.poi.xssf.usermodel.XSSFDrawing.<init>(XSSFDrawing.java:97)
        at
org.apache.poi.xssf.eventusermodel.XSSFReader$SheetIterator.getShapes(XSSFReader.java:322)
        at
org.apache.tika.parser.microsoft.ooxml.XSSFExcelExtractorDecorator.buildXHTML(XSSFExcelExtractorDecorator.java:162)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60584] NPE with missing Drawing in XSSFReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60584

--- Comment #2 from Javen O'Neal <on...@apache.org> ---
Looks fine to me. Is this a rare cases that would warrant a log.info or
log.warn level entry?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60584] NPE with missing Drawing in XSSFReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60584

Tim Allison <ta...@mitre.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Tim Allison <ta...@mitre.org> ---
Thank you, Javen.  Added logging: warn.

r1778664

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60584] NPE with missing Drawing in XSSFReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60584

Tim Allison <ta...@mitre.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Tim Allison <ta...@mitre.org> ---
Any objections if we add a null check in getShapes()

                  PackagePart drawingsPart =
sheetPkg.getPackage().getPart(drawingsName);
                  if (drawingsPart == null) {
                      //parts can go missing; Excel ignores them silently --
TIKA-2134/POI 60584
                      continue;
                  }

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org