You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 17:47:48 UTC

[PR] test: cover selection and range rules in MetricQueryDTO [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3521:
URL: https://github.com/apache/rocketmq-dashboard/pull/3521

   ### Summary
   
   `MetricQueryDTO` enforces the raw-vs-semantic selection contract plus positive range bounds and a step. It had no direct tests (only controller-level coverage).
   
   ### Changes
   
   - Raw metric queries and complete profile/semantic pairs pass validation
   - A semantic metric or profile without its counterpart is rejected
   - A query without any selection is rejected
   - Mixing a raw metric with a semantic selection is rejected
   - Non-positive start/end and a blank step are rejected
   
   ### Testing
   
   `mvn test -Dtest=MetricQueryDTOTest` passes: 5 tests, 0 failures (first coverage for this DTO).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: cover selection and range rules in MetricQueryDTO [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3521: test: cover selection and range rules in MetricQueryDTO
URL: https://github.com/apache/rocketmq-dashboard/pull/3521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org