You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jaydoane <gi...@git.apache.org> on 2015/11/02 02:07:21 UTC
[GitHub] couchdb-chttpd pull request: Explicitly create admin user and auth...
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/91
Explicitly create admin user and authenticate requests in chttpd_db_test cases
This patch explicitly configures an admin user and then makes all requests using that user's credentials. This approach continues to work under the CouchDB's security model, and also allows the tests to pass under Cloudant's security model.
COUCHDB-2865
BugzID: 55502
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-chttpd 55502-chttpd_db_test-explicit-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 68d40cce7d89e86515dec88ff2899bafb1ee3e0c
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-02T00:59:32Z
Explicitly create admin user and authenticate requests in chttpd_db_test cases
COUCHDB-2865
BugzID: 55502
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Explicitly create admin user and auth...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/91#issuecomment-152932268
LGFM, though this isn't the only place where we do HTTP requests from Erlang to CouchDB API and you may need more generalized way to define ?AUTH. But let's postpone this till the next need in this.
Btw, iirc, branch name shouldn't contain bugzid, but jira one (not sure about commit message). Is it all ok with Cloudant policies?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Explicitly create admin user and auth...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Explicitly create admin user and auth...
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/91#issuecomment-153115083
@kxepal, thanks for the review. I believe you are correct that there are other tests which also rely on implicit "admin party" authorization, and I will tackle those as I come to them.
I also confirmed with Robert Newson that you are correct about the branch name and reference. I was under the mistaken impression that I should open an issue in each bug tracker (since from Cloudant's perspective, this is a bug, but from CouchDB's perspective, it's an enhancement). However, moving forward, I will just use JIRA for issues such as this.
I don't have a commit bit, so can you merge this for me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Explicitly create admin user and auth...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/91#issuecomment-153116297
@jaydoane Landed. Since you have JIRA issue ticket and traceback magic word, we're fine here (: Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---