You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2018/10/14 00:19:20 UTC
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11682
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
IMPALA-5031: Undefined uninitialized bool read
This fixes a bug in cpp-mustache that was already fixed in its
upstream repository
(https://github.com/henryr/cpp-mustache/commit/7efdb810e). Without
this fix, the code reads something like:
bool foo;
MaybeSetValue(&foo);
ReadValue(foo);
Because MaybeSetValue might not set the vale of foo, foo might be
uninitialized in the call ReadValue(foo), which is undefined behavior
at the call site when foo is read. The standard says, in
[basic.fundamental]:
Using a bool value in ways described by this International
Standard as "undefined," such as by examining the value of an
uninitialized automatic object, might cause it to behave as if it
is neither true nor false.
Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
---
M be/src/thirdparty/mustache/mustache.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/11682/1
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11682 )
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michal Ostrowski <mo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 00:42:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Posted by "Michal Ostrowski (Code Review)" <ge...@cloudera.org>.
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11682 )
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michal Ostrowski <mo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 15:49:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11682 )
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michal Ostrowski <mo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:51:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11682 )
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michal Ostrowski <mo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 16:02:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11682 )
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3312/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michal Ostrowski <mo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:51:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11682 )
Change subject: IMPALA-5031: Undefined uninitialized bool read
......................................................................
IMPALA-5031: Undefined uninitialized bool read
This fixes a bug in cpp-mustache that was already fixed in its
upstream repository
(https://github.com/henryr/cpp-mustache/commit/7efdb810e). Without
this fix, the code reads something like:
bool foo;
MaybeSetValue(&foo);
ReadValue(foo);
Because MaybeSetValue might not set the vale of foo, foo might be
uninitialized in the call ReadValue(foo), which is undefined behavior
at the call site when foo is read. The standard says, in
[basic.fundamental]:
Using a bool value in ways described by this International
Standard as "undefined," such as by examining the value of an
uninitialized automatic object, might cause it to behave as if it
is neither true nor false.
Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Reviewed-on: http://gerrit.cloudera.org:8080/11682
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/thirdparty/mustache/mustache.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b32a5dd3afc3f2d847be37766aa0f7e53af32a3
Gerrit-Change-Number: 11682
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michal Ostrowski <mo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>