You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/14 02:28:37 UTC

[GitHub] [commons-pool] garydgregory commented on pull request #43: Add DestroyMode to provide context to destroyObject activations. Fixe…

garydgregory commented on pull request #43:
URL: https://github.com/apache/commons-pool/pull/43#issuecomment-691775229


   @psteitz 
   LGTM & TY. I will merge in the AM with fresh eyes. The only item I will modify after a merge, or you can do here, it is to add Javadoc `since` tags for all new public methods, and since we have new APIs, the `since` will be for 2.9.0 instead of 2.8.2.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org