[GitHub] [dubbo] xiaoheng1 commented on a change in pull request #8492: Solve the problem of address delivery in service discovery scenarios

[GitBox <gi...@apache.org>]

xiaoheng1 commented on a change in pull request #8492:
URL: https://github.com/apache/dubbo/pull/8492#discussion_r688287538



##########
File path: dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/InstanceAddressURL.java
##########
@@ -62,30 +62,38 @@ public MetadataInfo getMetadataInfo() {
 
     @Override
     public String getServiceInterface() {
-        return RpcContext.getServiceContext().getInterfaceName();
+        String serviceInterface = RpcContext.getServiceContext().getInterfaceName();
+        return StringUtils.isEmpty(serviceInterface) ? super.getParameter(INTERFACE_KEY) : serviceInterface;
     }
 
+    @Override
     public String getGroup() {
-        return RpcContext.getServiceContext().getGroup();
+        String group = RpcContext.getServiceContext().getGroup();
+        return StringUtils.isEmpty(group) ? super.getGroup() : group;

Review comment:
       Okay, I set consumerUrl to ServiceContext in AbstractClusterInvoker.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org