[GitHub] [superset] rusackas commented on pull request #21143: fix(plugin-chart-handlebars): Fixed issue with Helpers

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #21143:
URL: https://github.com/apache/superset/pull/21143#issuecomment-1404222109

   @sinhashubham95 @villebro just checking in on this... wondering if I'm off base in my prior assessment. 
   
   The build issue was resolved quite some time ago, and I don't think the moment dependency is a big deal, personally. 
   
   Is anyone still clamoring to get this lib copied/pasted into our codebase, and willing to maintain it? If not, I think we should probably forego this change and close the PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org