You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/22 15:26:09 UTC

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7514: ARROW-6235 : [R] Implement conversion from arrow::BinaryArray to R character vector

fsaintjacques commented on a change in pull request #7514:
URL: https://github.com/apache/arrow/pull/7514#discussion_r443639526



##########
File path: r/src/array_to_vector.cpp
##########
@@ -693,6 +741,9 @@ std::shared_ptr<Converter> Converter::Make(const std::shared_ptr<DataType>& type
     case Type::BOOL:
       return std::make_shared<arrow::r::Converter_Boolean>(std::move(arrays));
 
+    case Type::BINARY:

Review comment:
       Since this is in your mental cache, we can accept FIXED_BINARY and LARGE_BINARY with minimal effort by using `GetView` instead (and some template dispatching because they don't share the same base class). LARGE_BINARY will require to bound check each value with INT32_MAX.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org