You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/06 18:48:03 UTC
[GitHub] [hadoop-ozone] frischHWC opened a new pull request #1478: Fix inconsistenc recon config keys starting with recon and not ozone
frischHWC opened a new pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478
## What changes were proposed in this pull request?
Fix recon configs inconsistent
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4309?jql=project%20in%20(HDDS)%20AND%20labels%20in%20(newbie)%20AND%20assignee%20is%20EMPTY%20AND%20status%20in%20(open%2C%20Reopened)
## How was this patch tested?
Build up project, launch dockers, and new default parameters were present but not old ones anymore.
On recon container:
```
> ozone getconf confKey recon.om.socket.timeout
Configuration recon.om.socket.timeout is missing.
> ozone getconf confKey ozone.recon.om.socket.timeout
5s
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1478: Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-704627172
@frischHWC Thanks for working on this! The patch looks good to me except the failing checkstyles. Please fix those longer lines and I can merge it.
```
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServerConfigKeys.java
74: Line is longer than 80 characters (found 86).
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java
128: Line is longer than 80 characters (found 82).
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/PrometheusServiceProviderImpl.java
68: Line is longer than 80 characters (found 84).
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManager.java
99: Line is longer than 80 characters (found 82).
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java
72: Line is longer than 80 characters (found 82).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-io commented on pull request #1478: Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-704962201
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=h1) Report
> Merging [#1478](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/f9b1ca45fdeaaa63b9355c5c54fafc96ddf4597e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1478 +/- ##
=========================================
Coverage 75.49% 75.49%
Complexity 10798 10798
=========================================
Files 1021 1021
Lines 52095 52095
Branches 5103 5103
=========================================
Hits 39328 39328
Misses 10321 10321
Partials 2446 2446
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=footer). Last update [f9b1ca4...a2bd180](https://codecov.io/gh/apache/hadoop-ozone/pull/1478?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1478: Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#discussion_r500733595
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java
##########
@@ -205,12 +205,12 @@ public void start() {
}
reconTaskController.start();
long initialDelay = configuration.getTimeDuration(
- RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
- RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT,
+ OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
+ OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT,
Review comment:
```suggestion
OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
configuration.get(
ReconServerConfigKeys.RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT),
```
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServerConfigKeys.java
##########
@@ -60,31 +60,31 @@
public static final String RECON_STORAGE_DIR = "recon";
- public static final String RECON_OM_SOCKET_TIMEOUT =
- "recon.om.socket.timeout";
- public static final String RECON_OM_SOCKET_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_SOCKET_TIMEOUT =
+ "ozone.recon.om.socket.timeout";
+ public static final String OZONE_RECON_OM_SOCKET_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_CONNECTION_TIMEOUT =
- "recon.om.connection.timeout";
- public static final String RECON_OM_CONNECTION_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_CONNECTION_TIMEOUT =
+ "ozone.recon.om.connection.timeout";
+ public static final String OZONE_RECON_OM_CONNECTION_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_CONNECTION_REQUEST_TIMEOUT =
- "recon.om.connection.request.timeout";
+ public static final String OZONE_RECON_OM_CONNECTION_REQUEST_TIMEOUT =
+ "ozone.recon.om.connection.request.timeout";
- public static final String RECON_OM_CONNECTION_REQUEST_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_CONNECTION_REQUEST_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
- "recon.om.snapshot.task.initial.delay";
+ public static final String OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
+ "ozone.recon.om.snapshot.task.initial.delay";
Review comment:
```suggestion
public static final String OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
"ozone.recon.om.snapshot.task.initial.delay";
@Deprecated
public static final String RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
"recon.om.snapshot.task.initial.delay";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1478: HDDS-4309. Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-705037905
@adoroszlai Thanks for the review and @frischHWC thanks for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1478: Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] frischHWC commented on a change in pull request #1478: Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
frischHWC commented on a change in pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#discussion_r500779381
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServerConfigKeys.java
##########
@@ -60,31 +60,31 @@
public static final String RECON_STORAGE_DIR = "recon";
- public static final String RECON_OM_SOCKET_TIMEOUT =
- "recon.om.socket.timeout";
- public static final String RECON_OM_SOCKET_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_SOCKET_TIMEOUT =
+ "ozone.recon.om.socket.timeout";
+ public static final String OZONE_RECON_OM_SOCKET_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_CONNECTION_TIMEOUT =
- "recon.om.connection.timeout";
- public static final String RECON_OM_CONNECTION_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_CONNECTION_TIMEOUT =
+ "ozone.recon.om.connection.timeout";
+ public static final String OZONE_RECON_OM_CONNECTION_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_CONNECTION_REQUEST_TIMEOUT =
- "recon.om.connection.request.timeout";
+ public static final String OZONE_RECON_OM_CONNECTION_REQUEST_TIMEOUT =
+ "ozone.recon.om.connection.request.timeout";
- public static final String RECON_OM_CONNECTION_REQUEST_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_CONNECTION_REQUEST_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
- "recon.om.snapshot.task.initial.delay";
+ public static final String OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
+ "ozone.recon.om.snapshot.task.initial.delay";
Review comment:
You are right, I just added these deprecated configurations in a new commit!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1478: Fix inconsistency recon config keys starting with recon and not ozone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#issuecomment-704792520
Thanks @frischHWC for updating the patch. Sorry, I forgot `TestOzoneConfigurationFields`, a unit test that checks whether properties in `ozone-default.xml` and the `*ConfigKeys` classes are in sync. We need to enumerate the deprecated constants in `addPropertiesNotInXml`, since these are no longer present in the XML.
https://github.com/apache/hadoop-ozone/blob/f9b1ca45fdeaaa63b9355c5c54fafc96ddf4597e/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java#L60-L76
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org