You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/07 10:01:47 UTC

[GitHub] [maven-javadoc-plugin] pzygielo opened a new pull request, #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

pzygielo opened a new pull request, #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158

   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#discussion_r940602540


##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java:
##########
@@ -27,7 +27,7 @@
 import java.util.ResourceBundle;
 import java.util.stream.Collectors;
 
-import org.apache.maven.doxia.sink.Sink;
+import org.codehaus.doxia.sink.Sink;

Review Comment:
   @olamy If you read the reason for the change you'll see that it was my fault to replace this in a minor version. I am working on a followup to this to make it right. Unfortunately, MJAVADOC does not/cannot use maven-reporting-impl which would make this much easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] olamy commented on a diff in pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#discussion_r939653679


##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java:
##########
@@ -27,7 +27,7 @@
 import java.util.ResourceBundle;
 import java.util.stream.Collectors;
 
-import org.apache.maven.doxia.sink.Sink;
+import org.codehaus.doxia.sink.Sink;

Review Comment:
   ??
   I don't think it's a right change. but looks to be back in the past :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] michael-o commented on pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#issuecomment-1208547448

   Folks, eyes please. This should now do it. Everything passes and it should now be like using m-r-impl. Maven JXR passes with this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] pzygielo commented on a diff in pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#discussion_r939654431


##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java:
##########
@@ -27,7 +27,7 @@
 import java.util.ResourceBundle;
 import java.util.stream.Collectors;
 
-import org.apache.maven.doxia.sink.Sink;
+import org.codehaus.doxia.sink.Sink;

Review Comment:
   > ?? I don't think it's a right change. but looks to be back in the past :)
   
   I think that's why MSHARED-1118 has "Restore" in its title
   - https://github.com/apache/maven-reporting-api/pull/13



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] olamy commented on a diff in pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#discussion_r939655192


##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java:
##########
@@ -27,7 +27,7 @@
 import java.util.ResourceBundle;
 import java.util.stream.Collectors;
 
-import org.apache.maven.doxia.sink.Sink;
+import org.codehaus.doxia.sink.Sink;

Review Comment:
   doh :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] michael-o commented on pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#issuecomment-1209769750

   Guys, please check. This is a blocker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] pzygielo commented on pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1

Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158#issuecomment-1208595269

   I confirm that on my side - plugin with such change (3.4.1-SNAPSHOT a10f0b11e89fd65d61938186ddf16fb86ded239e) works fine when forked by m-site-plugin:3.12.1
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-javadoc-plugin] asfgit merged pull request #158: [MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0

Posted by GitBox <gi...@apache.org>.
asfgit merged PR #158:
URL: https://github.com/apache/maven-javadoc-plugin/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org