You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2025/08/11 16:28:04 UTC
[PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
kaxil opened a new pull request, #54362:
URL: https://github.com/apache/airflow/pull/54362
The error occurred when trying to access `dag_run.created_dag_version` on a DagRun object that was detached from its SQLAlchemy session.
Stacktrace:
```
[2025-08-08T19:03:28.761+0000] {scheduler_job_runner.py:935} ERROR - Marking task instance <TaskInstance: sell_oms_shipconfirm_mao_to_ecom_load_delta_quarterly.shipconfirm_delta_to_kafka_notebook_task scheduled__2025-08-08T07:30:00+00:00 [running]> as failed
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/airflow/jobs/scheduler_job_runner.py", line 925, in process_executor_events
dag = scheduler_dag_bag.get_dag(dag_run=ti.dag_run, session=session)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/airflow/jobs/scheduler_job_runner.py", line 141, in get_dag
version = self._version_from_dag_run(dag_run=dag_run, session=session)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/airflow/jobs/scheduler_job_runner.py", line 135, in _version_from_dag_run
dag_version = dag_run.created_dag_version
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/attributes.py", line 487, in __get__
return self.impl.get(state, dict_)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/attributes.py", line 959, in get
value = self._fire_loader_callables(state, key, passive)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/attributes.py", line 995, in _fire_loader_callables
return self.callable_(state, passive)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/sqlalchemy/orm/strategies.py", line 863, in _load_for_state
raise orm_exc.DetachedInstanceError(
sqlalchemy.orm.exc.DetachedInstanceError: Parent instance <DagRun at 0x7f46d309a5d0> is not bound to a Session; lazy load operation of attribute 'created_dag_version' cannot proceed (Background on this error at: https://sqlalche.me/e/14/bhk3)
```
Two-layer fix:
1. Proactive loading: Add `selectinload` for `created_dag_version` in `process_executor_events` query to ensure optimal performance for this critical path
2. Defensive code: Add relationship loading check in `DBDagBag._version_from_dag_run` to handle all call sites safely using SQLAlchemy inspect pattern
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #54362:
URL: https://github.com/apache/airflow/pull/54362#discussion_r2267471338
##########
airflow-core/src/airflow/models/dagbag.py:
##########
@@ -752,7 +754,14 @@ def _version_from_dag_run(dag_run, session):
if dag_version:
return dag_version
- return dag_run.created_dag_version
+ # Check if created_dag_version relationship is already loaded to avoid DetachedInstanceError
+ info = inspect(dag_run)
+ if info.attrs.created_dag_version.loaded_value is not NO_VALUE:
+ # Relationship is already loaded, safe to access
+ return dag_run.created_dag_version
+
+ # Relationship not loaded, fetch it explicitly from current session
+ return session.get(DagVersion, dag_run.created_dag_version_id)
Review Comment:
How about we set dag_run - dag_version relationship itself to load this info. I suggested this when @dstandish was working on this. dag_version is a lightweight table. Loading it when querying dag_run would have a very minimal impact and saves us from things like this in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #54362:
URL: https://github.com/apache/airflow/pull/54362#discussion_r2267493405
##########
airflow-core/src/airflow/models/dagbag.py:
##########
@@ -752,7 +754,14 @@ def _version_from_dag_run(dag_run, session):
if dag_version:
return dag_version
- return dag_run.created_dag_version
+ # Check if created_dag_version relationship is already loaded to avoid DetachedInstanceError
+ info = inspect(dag_run)
+ if info.attrs.created_dag_version.loaded_value is not NO_VALUE:
+ # Relationship is already loaded, safe to access
+ return dag_run.created_dag_version
+
+ # Relationship not loaded, fetch it explicitly from current session
+ return session.get(DagVersion, dag_run.created_dag_version_id)
Review Comment:
this `return dag_run.created_dag_version` already is using the relationship isn't it? but maybe you mean to suggest you make it eager load the object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #54362:
URL: https://github.com/apache/airflow/pull/54362#discussion_r2267504786
##########
airflow-core/src/airflow/models/dagbag.py:
##########
@@ -752,7 +754,14 @@ def _version_from_dag_run(dag_run, session):
if dag_version:
return dag_version
- return dag_run.created_dag_version
+ # Check if created_dag_version relationship is already loaded to avoid DetachedInstanceError
+ info = inspect(dag_run)
+ if info.attrs.created_dag_version.loaded_value is not NO_VALUE:
+ # Relationship is already loaded, safe to access
+ return dag_run.created_dag_version
+
+ # Relationship not loaded, fetch it explicitly from current session
+ return session.get(DagVersion, dag_run.created_dag_version_id)
Review Comment:
Let's get this issue unblocked and Ephraim & Daniel will decide on the longer term solution i.e. if we want to eagerly load the relationship or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #54362:
URL: https://github.com/apache/airflow/pull/54362#discussion_r2267471338
##########
airflow-core/src/airflow/models/dagbag.py:
##########
@@ -752,7 +754,14 @@ def _version_from_dag_run(dag_run, session):
if dag_version:
return dag_version
- return dag_run.created_dag_version
+ # Check if created_dag_version relationship is already loaded to avoid DetachedInstanceError
+ info = inspect(dag_run)
+ if info.attrs.created_dag_version.loaded_value is not NO_VALUE:
+ # Relationship is already loaded, safe to access
+ return dag_run.created_dag_version
+
+ # Relationship not loaded, fetch it explicitly from current session
+ return session.get(DagVersion, dag_run.created_dag_version_id)
Review Comment:
How about we set dag_run - dag_version relationship itself to load this info. I suggested this when @dstandish was working on this. dag_version is a lightweight table. Loading it when querying dag_run would have a very minimal impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #54362:
URL: https://github.com/apache/airflow/pull/54362#issuecomment-3175790641
cc @karenbraganz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #54362:
URL: https://github.com/apache/airflow/pull/54362#issuecomment-3176135216
Manually cherry-picked https://github.com/apache/airflow/commit/364d2468a18defafadeadffe18e73b8848a6112c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54362:
URL: https://github.com/apache/airflow/pull/54362#issuecomment-3176028904
### Backport failed to create: v3-0-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/16887328845'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-0-test</td>
<td><a href="https://github.com/apache/airflow/commit/05d2229d0e1b3aeec7b196ef007384d16350f3a1"><img src='https://img.shields.io/badge/Commit-05d2229-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 05d2229 v3-0-test
```
This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `DetachedInstanceError` when accessing `DagRun.created_dag_version` [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #54362:
URL: https://github.com/apache/airflow/pull/54362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org