You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/02/12 18:18:18 UTC
[PR] HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE [hbase]
liuxiaocs7 opened a new pull request, #7745:
URL: https://github.com/apache/hbase/pull/7745
see: HBASE-28913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7745:
URL: https://github.com/apache/hbase/pull/7745#discussion_r2846929906
##########
hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/master/balancer/LoadBalancerPerformanceEvaluation.java:
##########
@@ -85,6 +95,13 @@ private void setupConf() {
conf.setClass(HConstants.HBASE_MASTER_LOADBALANCER_CLASS, loadBalancerClazz,
LoadBalancer.class);
loadBalancer = LoadBalancerFactory.getLoadBalancer(conf);
+ loadBalancer.setClusterInfoProvider(new DummyClusterInfoProvider(conf));
+ try {
+ loadBalancer.initialize();
Review Comment:
We need to invoke `initialize` first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 merged PR #7745:
URL: https://github.com/apache/hbase/pull/7745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #7745:
URL: https://github.com/apache/hbase/pull/7745#issuecomment-3894743037
Is it possible to add a simple UT for LBPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7745:
URL: https://github.com/apache/hbase/pull/7745#discussion_r2846940458
##########
hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/master/balancer/LoadBalancerPerformanceEvaluation.java:
##########
@@ -178,4 +195,96 @@ public static void main(String[] args) throws IOException {
tool.setConf(HBaseConfiguration.create());
tool.run(args);
}
+
+ private static class DummyClusterInfoProvider implements ClusterInfoProvider {
Review Comment:
We have the same class `DummyClusterInfoProvider` in hbase-balancer, but in test-jar, it cannot be used directly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #7745:
URL: https://github.com/apache/hbase/pull/7745#issuecomment-3951578689
> Is it possible to add a simple UT for LBPE?
Hi, @Apache9, UT for LBPE has been created, please take a look when free, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org