[jira] Updated: (WICKET-1115) DownloadLink fix that encodes non-ASCII file names properly

["Johan Compagner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner updated WICKET-1115:
------------------------------------

    Fix Version/s: 1.4.0-alpha

Did you patch it already so that also it works fine in IE7?
Also can you make a real patch so not the file itself but a svn-patch? Because the download file is already changed so then the merging is much easier.
i don't like that we need to include commons-codec just for this. So if you make a patch please copy them from that lib and include them into a wicket package.

> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
>                 Key: WICKET-1115
>                 URL: https://issues.apache.org/jira/browse/WICKET-1115
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.2.6
>         Environment: Internet Explorer 6, Firefox 2.0.0.8
>            Reporter: Volodymyr Sobotovich
>             Fix For: 1.4.0-alpha
>
>         Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.