[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1234: MINIFICPP-1699 Add kubernetes-client/c library dependency

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r780444392



##########
File path: thirdparty/kubernetes-client-c/remove-findpackage.patch
##########
@@ -0,0 +1,12 @@
+diff --git a/kubernetes/PreTarget.cmake b/kubernetes/PreTarget.cmake
+index 93ea00e..1e064b8 100644
+--- a/kubernetes/PreTarget.cmake
++++ b/kubernetes/PreTarget.cmake
+@@ -41,6 +41,3 @@ list(APPEND HDRS
+         websocket/kube_exec.h
+         include/generic.h
+         include/utils.h)
+-
+-find_package(libwebsockets CONFIG REQUIRED)
+-find_package(yaml CONFIG REQUIRED)

Review comment:
       Consider adding dummy find modules under `cmake/libwebsockets/dummy` and `cmake/yaml/dummy`. See the existing ones for example. These directories are added to the cmake module path in our root CMakeLists.txt. This approach would make find_package work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org