[GitHub] [accumulo] ctubbsii commented on issue #1115: Simplify Maven Pom

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1115: Simplify Maven Pom
URL: https://github.com/apache/accumulo/issues/1115#issuecomment-485417128
 
 
   I think it is a mistake to characterize this as a simplification. It would only be simpler for use cases which shortcut important checks. It wouldn't be simpler for the use case of actually running our verification checks. I don't think newer developers unfamiliar with Maven should be appending any skip options. Skipping checks should require some knowledge of what you are doing. The default should not be to skip quality assurance/verification plugins.
   
   The whole point of running through to the `verify` phase is to verify the build... that means running all the verification checks. Users should not be skipping these verification checks unless they know what they are doing. I do not think the default run of `verify` phase should be to run fewer verification checks.
   
   We frequently have developers checking in code which fails verification steps, because they've gotten into the practice of skipping these checks (a bad habit, I think). Skipping verification plugins by default during the verify phase would encourage more of that stuff to fall through, increasing the likelihood of reduced code quality until another developer steps in and closes the gap.
   
   We've already added a `-PskipQA` profile, which was not in favor of. Why is that profile insufficient?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services