You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/05/01 00:34:09 UTC

[kudu-CR] [java] Fix a scan bug which will read repetitive rows.

Hello Alexey Serbin, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18420

to look at the new patch set (#20).

Change subject: [java] Fix a scan bug which will read repetitive rows.
......................................................................

[java] Fix a scan bug which will read repetitive rows.

When isFaultTolerant is true, from 2nd ScanRequest, in its response
callback function, lastPrimaryKey is not updated.

In common scenarios, when tablet server hosting the leader replica
restarts, Scanners will read rows from the first
ScanResponse's lastPrimaryKey, that will return some repetitive rows.

Change-Id: I4d6be9df10c1a45cd971b52a0351028c1f5a023f
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowErrorsAndOverflowStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
4 files changed, 170 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/18420/20
-- 
To view, visit http://gerrit.cloudera.org:8080/18420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d6be9df10c1a45cd971b52a0351028c1f5a023f
Gerrit-Change-Number: 18420
Gerrit-PatchSet: 20
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>