You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Matthew T. Adams (Created) (JIRA)" <ji...@apache.org> on 2012/03/08 05:27:03 UTC
[jira] [Created] (JDO-707) Refactor JDO parent & child poms
Refactor JDO parent & child poms
--------------------------------
Key: JDO-707
URL: https://issues.apache.org/jira/browse/JDO-707
Project: JDO
Issue Type: Improvement
Components: api, tck
Affects Versions: JDO 3 maintenance release 1 (3.1)
Reporter: Matthew T. Adams
Assignee: Matthew T. Adams
Fix For: JDO 3 maintenance release 1 (3.1)
Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew T. Adams updated JDO-707:
---------------------------------
Attachment: JDO-707-1.patch
This patch effectively changes the root pom to be a simple multimodule pom and creates a new module, parent-pom, to house a new, JDO parent pom and changes the api, exectck & tck modules to inherit it.
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: JDO-707-1.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew T. Adams updated JDO-707:
---------------------------------
Attachment: jdo-707.patch
New patch, adding inadvertently omitted parent-pom directory.
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: jdo-707.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226265#comment-13226265 ]
Matthew T. Adams commented on JDO-707:
--------------------------------------
The improvement comes when we release the 3.1 artifacts to Maven Central. When I released 3.0.1, I had to manually copy information from the parent pom into the JDO API pom. In 3.1, when we release, we should release not only artifact jdo-api, but also parent-pom. Then, there will not have to be any manual copying from the parent pom into the jdo-api pom.
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: JDO-707-1.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-707) Refactor JDO parent & child poms
Posted by "Craig L Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273414#comment-13273414 ]
Craig L Russell commented on JDO-707:
-------------------------------------
I think the version numbers should be hard coded, and not be substituted via ${project.version}. This is the advice I was given by the maven experts. The version is required for defining the version in the pom, but not required for declaring the dependencies.
Specifically, in tck/pom.xml, <version>3.1-SNAPSHOT</version> should not be removed. In the <plugin> element and <dependency> element, the version number should either be removed (allow the parent pom to define the version number) or should be retained.
In exectck/pom.xml, <version>1.0-SNAPSHOT</version> should not be removed. The changes @@ -69,6 +67,11 @@ and @@ -89,10 +92,6 @@ are unnecessary.
In api/pom.xml, <version>3.1-SNAPSHOT</version> should not be removed.
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: JDO-707-1.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew T. Adams updated JDO-707:
---------------------------------
Attachment: (was: jdo-707.patch)
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: jdo-707.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-707) Refactor JDO parent & child poms
Posted by "Michelle Caisse (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226253#comment-13226253 ]
Michelle Caisse commented on JDO-707:
-------------------------------------
Wondering what the benefit is of this change over the existing setup?
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: JDO-707-1.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew T. Adams updated JDO-707:
---------------------------------
Attachment: jdo-707.patch
New patch for review.
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: jdo-707.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew T. Adams updated JDO-707:
---------------------------------
Attachment: (was: JDO-707-1.patch)
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JDO-707) Refactor JDO parent & child poms
Posted by "Matthew T. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew T. Adams resolved JDO-707.
----------------------------------
Resolution: Fixed
$ svn ci -m "JDO-707 Refactor JDO parent & child poms"
Sending api/pom.xml
Sending copyjdorijars/pom.xml
Sending exectck/pom.xml
Adding parent-pom
Adding parent-pom/pom.xml
Sending pom.xml
Sending tck/pom.xml
Transmitting file data ......
Committed revision 1391517.
> Refactor JDO parent & child poms
> --------------------------------
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
> Affects Versions: JDO 3 maintenance release 1 (3.1)
> Reporter: Matthew T. Adams
> Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: jdo-707.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it, then create a simple multimodule root pom which can be used to build all projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira