[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #369: [YUNIKORN-1040] add e2e test that re-starts the scheduler pod

[GitBox <gi...@apache.org>]

wilfred-s commented on pull request #369:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/369#issuecomment-1049456226


   I don't know what happened with my last update. I must have closed a browser window without saving.
   I think that @yangwwei is right the forward of the port has not been recreated after the restart and that will cause the issue for the rest of the tests.
   
   I would also suggest that we move this restart test to its own test suite. Instead of making this part of basic scheduling and causing those tests to fail we should create a "recovery & restart" suite. Move this restart test in there and we can then extend it with e2e recover tests.
   
   Using some more advanced ginkgo tricks we can then make sure these restart or recovery tests are run separate from all the others. Adding labels and splitting the ginkgo run into two runs would allow us to be more destructive in tests. I do think that it requires gingkgo v2 with these test labels. @ronazhan please some input on ginkgo v2 change also


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org