You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 19:12:06 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #23022: Fix Grid view run/task alignment
bbovenzi opened a new pull request, #23022:
URL: https://github.com/apache/airflow/pull/23022
In the Grid view, sometimes the dag runs were becoming unaligned with the task instances. This is because of how we calculated the width of the label column to make auto-scrolling to the end of the div work.
This PR fixes this by changing how we determine when to scroll by using a `ResizeObserver` and removes the need for any tracking of `tableWidth` via state.
Before:
After:
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #23022: Fix Grid view run/task alignment
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #23022:
URL: https://github.com/apache/airflow/pull/23022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23022: Fix Grid view run/task alignment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23022:
URL: https://github.com/apache/airflow/pull/23022#issuecomment-1101446197
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org