You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/14 15:48:06 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #6101: [AIRFLOW-5481] Allow Deleting Renamed DAGs

feluelle commented on a change in pull request #6101: [AIRFLOW-5481] Allow Deleting Renamed DAGs
URL: https://github.com/apache/airflow/pull/6101#discussion_r324428396
 
 

 ##########
 File path: tests/core.py
 ##########
 @@ -1696,6 +1696,15 @@ def test_delete_dag(self):
                 '--yes'])
         )
 
+        # Test to check that the DAG should be deleted even if
+        # the file containing it is not deleted
 
 Review comment:
   I think it would be better to just create a new test.
   `def test_delete_existing_dag(self)` or `def test_delete_dag_exists(self)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services