You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/02/01 08:35:32 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #39844: [SPARK-42275][CONNECT][PYTHON] Avoid using built-in list, dict in static typing

zhengruifeng opened a new pull request, #39844:
URL: https://github.com/apache/spark/pull/39844

   ### What changes were proposed in this pull request?
   Avoid using built-in list, dict in static typing
   
   
   ### Why are the changes needed?
   it's not supported in python 3.8, see https://peps.python.org/pep-0585/
   
   python 3.8
   ```
   >>> from typing import List
   >>> a : List[str] = ["a", "b"]
   >>> a : list[str] = ["a", "b"]
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   TypeError: 'type' object is not subscriptable
   ```
   
   python 3.9
   ```
   >>> from typing import List
   >>> a : List[str] = ["a", "b"]
   >>> a : list[str] = ["a", "b"]
   
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   no
   
   
   ### How was this patch tested?
   manually check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #39844: [SPARK-42275][CONNECT][PYTHON] Avoid using built-in list, dict in static typing

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39844:
URL: https://github.com/apache/spark/pull/39844#issuecomment-1413027795

   Merged to master and branch-3.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #39844: [SPARK-42275][CONNECT][PYTHON] Avoid using built-in list, dict in static typing

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #39844: [SPARK-42275][CONNECT][PYTHON] Avoid using built-in list, dict in static typing
URL: https://github.com/apache/spark/pull/39844


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org